Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong default value for enable-brotli #2566

Merged
merged 1 commit into from
May 24, 2018

Conversation

webwurst
Copy link
Contributor

Brotli is disabled by default since c67e918.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2018
@aledbf
Copy link
Member

aledbf commented May 24, 2018

/approve
/lgtm

@aledbf
Copy link
Member

aledbf commented May 24, 2018

@webwurst thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, webwurst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #2566 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   40.63%   40.69%   +0.05%     
==========================================
  Files          74       74              
  Lines        5094     5094              
==========================================
+ Hits         2070     2073       +3     
+ Misses       2743     2741       -2     
+ Partials      281      280       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 25.95% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b946b68...0c2aa4b. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit a118a78 into kubernetes:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants