Disable resync period #2634
Disable resync period #2634
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
size/S
aledbf
force-pushed
the
sync-0
branch
3 times, most recently
from
af9a261 to
47e2cee
Compare
.travis.yml
Outdated
| && go get golang.org/x/lint/golint | ||
| - go get github.com/vbatts/git-validation | ||
| - | | ||
| mkdir -p $GOPATH/src/golang.org/x/tools |
There was a problem hiding this comment.
Maybe just go get -d golang.org/x/lint/golint to avoid this mkdir + git clone?
.travis.yml
Outdated
| git clone https://go.googlesource.com/tools $GOPATH/src/golang.org/x/tools | ||
| cd $GOPATH/src/golang.org/x/tools | ||
| git checkout release-branch.go1.10 | ||
| go get golang.org/x/lint/golint |
There was a problem hiding this comment.
go install sounds more appropriate.
.travis.yml
Outdated
| cd $GOPATH/src/golang.org/x/tools | ||
| git checkout release-branch.go1.10 | ||
| go get golang.org/x/lint/golint | ||
| cd $TRAVIS_BUILD_DIR |
There was a problem hiding this comment.
cd - probably more intuitive.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2634 +/- ##
==========================================
+ Coverage 40.69% 40.72% +0.02%
==========================================
Files 75 75
Lines 5123 5120 -3
==========================================
Hits 2085 2085
+ Misses 2756 2753 -3
Partials 282 282
Continue to review full report at Codecov.
|
|
Resync period is there for a good reason to catchup with missed watch events, which can occasionally happen. In source controllers (code in controller-manager) do just fine with resync period != 0. Having read all related issues, there was no evidence that problems were caused. |
What this PR does / why we need it:
Disables the resync period. The intended use of this setting is related to watch issues with etcd. This is not an issue anymore. Additionally, forcing a resync introduces some edge cases, like #2195.
Note: this was also recommended in the contributor summit in last Kubecon
Which issue this PR fixes : fixes #2195