Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect uri for oauth2 login #2741

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

thomaspeitz
Copy link
Contributor

What this PR does / why we need it:
This improves documentation by oauth2 redirect uri handling. This allows
signing in and keeping the path. It cost me a lot of time to research this until
i found it somewhere hidden in bitly repository (bitly/oauth2_proxy#558). This will reduce research
for other users.

Which issue this PR fixes
There is no open issue.

Special notes for your reviewer:
Thanks for reviewing 👍

Greetings, Thomas

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2018
@codecov-io
Copy link

Codecov Report

Merging #2741 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2741   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files          73       73           
  Lines        5101     5101           
=======================================
  Hits         2087     2087           
  Misses       2725     2725           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5039e77...25f0b29. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2018
@aledbf
Copy link
Member

aledbf commented Jul 5, 2018

@tsupertramp thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, tsupertramp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 64cf1b9 into kubernetes:master Jul 5, 2018
@thomaspeitz thomaspeitz deleted the improve-docs-for-oauth branch July 18, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants