Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Rate over 2 minutes since default Prometheus interval is 1m #2884

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Aug 2, 2018

What this PR does / why we need it:

Prometheus' default scrape_interval is 1m, see prometheus doc, making irate(mymetrics{}[1m]) not return any data with the default scrape_interval.

In order to make this Grafana dashboard as easy to use as possible I think it should work out of the box with the Prometheus defaults, therefore I suggest to switch 1m for 2m but other values could also be useful.

Special notes for your reviewer:
Example: prometheus/prometheus#3194

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2018
@aledbf
Copy link
Member

aledbf commented Aug 4, 2018

@discordianfish WDYT about this?

@discordianfish
Copy link
Contributor

2m might be a better default, that's right. Even better though would be using $__interval and rate() instead of irate(). This has it's own problems though: grafana/grafana#11451

@Miouge1
Copy link
Contributor Author

Miouge1 commented Aug 21, 2018

I resolved the conflicts in the latest commit. I would suggest to move forward with this and see how the discussion with $__interval evolves.

@codecov-io
Copy link

Codecov Report

Merging #2884 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
- Coverage   47.58%   47.54%   -0.04%     
==========================================
  Files          77       76       -1     
  Lines        5634     5483     -151     
==========================================
- Hits         2681     2607      -74     
+ Misses       2600     2542      -58     
+ Partials      353      334      -19
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 11.28% <0%> (-4.76%) ⬇️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️
internal/net/net.go 72.72% <0%> (-2.28%) ⬇️
internal/ingress/annotations/annotations.go 80.64% <0%> (-0.31%) ⬇️
internal/ingress/controller/store/store.go 62.68% <0%> (-0.11%) ⬇️
internal/ingress/controller/config/config.go 98.26% <0%> (-0.05%) ⬇️
internal/ingress/sslcert.go 50% <0%> (ø) ⬆️
...ternal/ingress/annotations/backendprotocol/main.go
internal/ingress/controller/controller.go 2.22% <0%> (+0.02%) ⬆️
internal/ingress/types_equals.go 13.17% <0%> (+0.08%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c083599...3b63679. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 23, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2018
@aledbf
Copy link
Member

aledbf commented Aug 23, 2018

@Miouge1 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7882bb1 into kubernetes:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants