Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPV6 detection #2905

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix IPV6 detection #2905

merged 1 commit into from
Aug 6, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 6, 2018

Which issue this PR fixes: fixes #2904

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2018
@aledbf aledbf force-pushed the fix-ipv6 branch 2 times, most recently from 605fd3a to f8b3f93 Compare August 6, 2018 17:04
@codecov-io
Copy link

Codecov Report

Merging #2905 into master will increase coverage by 0.06%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
+ Coverage   47.58%   47.65%   +0.06%     
==========================================
  Files          76       76              
  Lines        5491     5500       +9     
==========================================
+ Hits         2613     2621       +8     
+ Misses       2543     2541       -2     
- Partials      335      338       +3
Impacted Files Coverage Δ
internal/net/net.go 75% <54.54%> (+2.27%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e96de...123ffc0. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c97a90f into kubernetes:master Aug 6, 2018
@aledbf aledbf deleted the fix-ipv6 branch August 6, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 wrongly enabled, causes "Cannot assign requested address"
4 participants