Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx dependencies #2925

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 10, 2018

What this PR does / why we need it:

Fix issue with zipkin ids opentracing-contrib/nginx-opentracing#52

Removes jemalloc and libatomic from nginx

@aledbf
Copy link
Member Author

aledbf commented Aug 10, 2018

/hold

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2018
@aledbf aledbf force-pushed the update-nginx branch 2 times, most recently from cf93d30 to 1c83b49 Compare August 10, 2018 23:38
@codecov-io
Copy link

codecov-io commented Aug 11, 2018

Codecov Report

Merging #2925 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
+ Coverage   47.55%   47.57%   +0.02%     
==========================================
  Files          77       77              
  Lines        5531     5532       +1     
==========================================
+ Hits         2630     2632       +2     
+ Misses       2562     2560       -2     
- Partials      339      340       +1
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 64.9% <0%> (+0.07%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9772c...365a1d9. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2018
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 56ed290 into kubernetes:master Aug 14, 2018
@aledbf aledbf deleted the update-nginx branch August 15, 2018 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants