Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in flags.go #2932

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Fixed typo in flags.go #2932

merged 1 commit into from
Aug 13, 2018

Conversation

onesolpark
Copy link
Contributor

Noticed a small typo while changing different configs for ssl-passthrough.
Flags.go, ssl-passtrough-proxy-port -> ssl-passthrough-proxy-port.

What this PR does / why we need it:
Fixed typo in flags.go (ssl-passthrough-proxy-port)

Special notes for your reviewer:
Not really a bug or anything but I guess I had to let you know just in case.

ssl-passthrough-proxy-port
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2018
@onesolpark
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 13, 2018
@codecov-io
Copy link

Codecov Report

Merging #2932 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2932   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files          77       77           
  Lines        5531     5531           
=======================================
  Hits         2631     2631           
  Misses       2560     2560           
  Partials      340      340
Impacted Files Coverage Δ
cmd/nginx/flags.go 83.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b8c2e...63aef5d. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 13, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, onesolpark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@aledbf
Copy link
Member

aledbf commented Aug 13, 2018

@onesolpark thanks!

@k8s-ci-robot k8s-ci-robot merged commit b72e208 into kubernetes:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants