Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document when to modify ELB idle timeouts and set default value to 60s #3046

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

mootpt
Copy link
Contributor

@mootpt mootpt commented Sep 6, 2018

What this PR does / why we need it:
This PR changes the default ELB idle timeout in the manifest to 60s. This is to allow connections to be properly closed by the ELB. By default, the NGINX keepalive_timeout is set to 75s and with the existing config of 3600s the ELB attempts to reuse closed connections.

Here is a link to the official AWS documentation that covers idle timeouts.

Special notes for your reviewer:

Slack thread: https://kubernetes.slack.com/archives/CANQGM8BA/p1536105979000100

The example in the Helm chart will also likely need to be updated

Please feel free to amend as necessary.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2018
@mootpt
Copy link
Contributor Author

mootpt commented Sep 6, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2018
@mootpt
Copy link
Contributor Author

mootpt commented Sep 6, 2018

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Sep 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, mootpt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2018
@aledbf
Copy link
Member

aledbf commented Sep 6, 2018

@mootpt thanks!

@k8s-ci-robot k8s-ci-robot merged commit 2be9262 into kubernetes:master Sep 6, 2018
@mootpt mootpt deleted the elb-timeouts branch September 6, 2018 17:28
@mootpt
Copy link
Contributor Author

mootpt commented Sep 6, 2018

sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants