Add e2e test for rewrite-target annotation kube-lego failure #3076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds and e2e-test for the edge case that currently breaks kube-lego. This issue causes requests to the path
/.well-known/acme/challenge
to be redirected to the/
path when the rewrite-target annotation is set for the index route.This annotation enforces the use of the
~*
location modifier. In NGINX, regex paths take priority over regular prefixes unless the=
or^~
location modifiers are used.Which issue this PR fixes :
Partially fixes https://github.com/Shopify/edgescale/issues/659
Special notes for your reviewer:
Currently this test will fail. Additional changes need to be made to prevent this issue from occurring.
Relevant links:
@ElvinEfendi @sbfaulkner