Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for rewrite-target annotation kube-lego failure #3076

Closed
wants to merge 1 commit into from

Conversation

zrdaley
Copy link
Contributor

@zrdaley zrdaley commented Sep 11, 2018

What this PR does / why we need it:
This PR adds and e2e-test for the edge case that currently breaks kube-lego. This issue causes requests to the path /.well-known/acme/challenge to be redirected to the / path when the rewrite-target annotation is set for the index route.

This annotation enforces the use of the ~* location modifier. In NGINX, regex paths take priority over regular prefixes unless the = or ^~ location modifiers are used.

Which issue this PR fixes :
Partially fixes https://github.com/Shopify/edgescale/issues/659

Special notes for your reviewer:
Currently this test will fail. Additional changes need to be made to prevent this issue from occurring.

Relevant links:

@ElvinEfendi @sbfaulkner

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zrdaley
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: caseydavenport

If they are not already assigned, you can assign the PR to them by writing /assign @caseydavenport in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2018
@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2018
@zrdaley
Copy link
Contributor Author

zrdaley commented Sep 12, 2018

See: #3078

@zrdaley zrdaley closed this Sep 12, 2018
@zrdaley zrdaley deleted the upstream-lego-e2e branch September 12, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants