<WIP>add expire time annotation #3081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hchenxa If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
hchenxa
force-pushed
the
hchenxa_sessionsticky
branch
4 times, most recently
from
66bb22f
to
55c95e2
Compare
hchenxa
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@hchenxa please add e2e tests |
hchenxa
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
hchenxa
force-pushed
the
hchenxa_sessionsticky
branch
from
55c95e2
to
8c63b67
Compare
k8s-ci-robot
added
size/S
hchenxa
force-pushed
the
hchenxa_sessionsticky
branch
from
8c63b67
to
a39b79e
Compare
k8s-ci-robot
added
size/M
hchenxa
changed the title
hchenxa
force-pushed
the
hchenxa_sessionsticky
branch
4 times, most recently
from
438d5c7
to
a5c8794
Compare
hchenxa
force-pushed
the
hchenxa_sessionsticky
branch
from
a5c8794
to
fbf90a9
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support more annotation for session sticky like cookie expire time.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
/assign @ElvinEfendi