Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for HealthCheck #3193

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add E2E tests for HealthCheck #3193

merged 1 commit into from
Oct 8, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Oct 5, 2018

Adds e2e tests for:

  • upstream-max-fails
  • upstream-fail-timeout

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2018
@aledbf
Copy link
Member

aledbf commented Oct 7, 2018

@diazjf please rebase to pass CI

@diazjf diazjf force-pushed the healthcheck-e2e branch 2 times, most recently from 317960b to 950806f Compare October 8, 2018 16:30
@diazjf diazjf mentioned this pull request Oct 8, 2018
Merged
Add E2E tests for HealthCheck
527805f 
Adds e2e tests for:

- upstream-max-fails
- upstream-fail-timeout
@aledbf
Copy link
Member

aledbf commented Oct 8, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@aledbf
Copy link
Member

aledbf commented Oct 8, 2018

@diazjf thanks!

@k8s-ci-robot k8s-ci-robot merged commit f3a2e50 into kubernetes:master Oct 8, 2018
ElvinEfendi
ElvinEfendi reviewed Oct 9, 2018
View reviewed changes
test/e2e/annotations/healthcheck.go

err = f.WaitForNginxConfiguration(
func(server string) bool {
return Expect(server).Should(ContainSubstring("max_fails=11 fail_timeout=0;"))
Copy link
Member

@ElvinEfendi ElvinEfendi Oct 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why would server section has this setting? Is it not about upstream peers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElvinEfendi its using the WaitForNginxConfiguration which looks at the whole config rather than just the server. I should have named (server, string) as (conf, string). Either way looks like this is gonna be deprecated :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

@antoineco antoineco Awaiting requested review from antoineco

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diazjf @aledbf @k8s-ci-robot @ElvinEfendi