Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for round robin load balancing #3390

Merged
merged 1 commit into from
Nov 9, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions test/e2e/settings/load_balance.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
Copyright 2018 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package settings

import (
"net/http"
"regexp"
"strings"
"time"

"github.com/parnurzeal/gorequest"

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"

"k8s.io/ingress-nginx/test/e2e/framework"
)

var _ = framework.IngressNginxDescribe("Load Balance", func() {
f := framework.NewDefaultFramework("load-balance")

setting := "load-balance"

BeforeEach(func() {
f.NewEchoDeploymentWithReplicas(3)
})

AfterEach(func() {
f.UpdateNginxConfigMapData(setting, "")

})

It("should evenly distribute requests with round-robin (default algorithm)", func() {
host := "load-balance.com"

f.EnsureIngress(framework.NewSingleIngress(host, "/", host, f.IngressController.Namespace, "http-svc", 80, nil))

f.WaitForNginxServer(host,
func(server string) bool {
return strings.Contains(server, "server_name load-balance.com")
})

re, _ := regexp.Compile(`http-svc.*`)
replicaRequestCount := map[string]int{}

for i := 0; i < 600; i++ {
_, body, errs := gorequest.New().
Get(f.IngressController.HTTPURL).
Set("Host", host).
Retry(10, 1*time.Second, http.StatusNotFound, http.StatusServiceUnavailable).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this? Does the endpoint expected to be flaky?

End()
Expect(len(errs)).Should(BeNumerically("==", 0))
Copy link
Member

@ElvinEfendi ElvinEfendi Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do this, the error message is useless. Please use Expect(errs).Should(BeEmpty()) instead (or if you know any better one - the idea is to reveal more about the error not just say n != m).


replica := re.FindString(body)
Expect(replica).ShouldNot(Equal(""))

if _, ok := replicaRequestCount[replica]; !ok {
replicaRequestCount[replica] = 1
} else {
replicaRequestCount[replica]++
}
}

acceptableRequestRange := []int{198, 199, 200, 201, 202}
for _, v := range replicaRequestCount {
Expect(acceptableRequestRange).Should(ContainElement(v))
}
})
})