Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare error with error types from k8s.io/apimachinery/pkg/api/errors #3503

Conversation

zhuguihua
Copy link

What this PR does / why we need it:
This PR is to compare error with error types from k8s.io/apimachinery/pkg/api/errors when cannot find default service.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2018
@zhuguihua zhuguihua force-pushed the compare_error_with_error_types_from_apimachinery branch 3 times, most recently from 4cbcc22 to c3b54da Compare December 3, 2018 12:08
Signed-off-by: Guihua Zhu <zhuguihua@cmss.chinamobile.com>
@zhuguihua zhuguihua force-pushed the compare_error_with_error_types_from_apimachinery branch from c3b54da to bb41a9d Compare December 7, 2018 07:47
@zhuguihua
Copy link
Author

/assign @bowei

@antoineco
Copy link
Contributor

/lgtm
Thanks for tackling my old TODO ;)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, zhuguihua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit 19b3b6b into kubernetes:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants