Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom election id for status sync. #351

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

danielqsj
Copy link
Contributor

@danielqsj danielqsj commented Feb 27, 2017

What this PR does / why we need it:

  • Multiple deployment/repliaset/daemonset of same ingress controller class can not work correctly in a same namespace.

Which issue this PR fixes:
Closes #350

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@danielqsj
Copy link
Contributor Author

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 27, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 45.733% when pulling 2d526b2 on danielqsj:master into 376519e on kubernetes:master.

@pieterlange
Copy link
Contributor

Nice one! I was just running into this 👍

One small nit: can't we just default the ElectionId to the value of class, as that should be a unique value anyway when deploying multiple sets of ingress controllers?

@danielqsj
Copy link
Contributor Author

@pieterlange Yeah, I also thought about it. But due to the document of nginx-ingress-controller recommends to use kubernetes.io/ingress.class: "nginx" , so I use a new param. But I still think reusing "class" is also fine.

@aledbf aledbf self-assigned this Feb 27, 2017
@aledbf
Copy link
Member

aledbf commented Feb 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2017
@aledbf
Copy link
Member

aledbf commented Feb 27, 2017

@danielqsj thanks!

@aledbf aledbf merged commit fb8e2d7 into kubernetes:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to enable custom election id for status sync
6 participants