-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for spec.rules.host format #3575
Add documentation for spec.rules.host format #3575
Conversation
d2891e1
to
e445994
Compare
/approve |
waiting LGTM from @ElvinEfendi |
See #3534 (comment) This is going to lead to more confusion since we support wildcard host everywhere else except session affinity. If we wanna go with changing docs then we should at least scope it for session affinity only. |
No, this works just because nginx supports wildcard hostnames and we don't have additional validations to avoid this scenario. I am always open to "bend" the rules, but this one is not something I want to break, introducing the idea that wildcard hostnames are allowed. The spec only allows wildcard hostnames in the TLS section, which is fine because of the nature of SSL certificates. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi, zrdaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Wildcards/regex are not supported in the
spec.rules.host
field of an ingress definition.Which issue this PR fixes : fixes #3534
cc: @ElvinEfendi @aledbf