Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for spec.rules.host format #3575

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

zrdaley
Copy link
Contributor

@zrdaley zrdaley commented Dec 18, 2018

What this PR does / why we need it:

Wildcards/regex are not supported in the spec.rules.host field of an ingress definition.

Which issue this PR fixes : fixes #3534

cc: @ElvinEfendi @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2018
@zrdaley zrdaley force-pushed the document-ingress-wildcard branch from d2891e1 to e445994 Compare December 18, 2018 17:54
@aledbf
Copy link
Member

aledbf commented Dec 19, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Dec 19, 2018

waiting LGTM from @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
@ElvinEfendi
Copy link
Member

See #3534 (comment)

This is going to lead to more confusion since we support wildcard host everywhere else except session affinity. If we wanna go with changing docs then we should at least scope it for session affinity only.

@aledbf
Copy link
Member

aledbf commented Dec 20, 2018

This is going to lead to more confusion since we support wildcard host everywhere else except session affinity.

No, this works just because nginx supports wildcard hostnames and we don't have additional validations to avoid this scenario. I am always open to "bend" the rules, but this one is not something I want to break, introducing the idea that wildcard hostnames are allowed.

The spec only allows wildcard hostnames in the TLS section, which is fine because of the nature of SSL certificates.

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi, zrdaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 22efaab into kubernetes:master Dec 20, 2018
@zrdaley zrdaley deleted the document-ingress-wildcard branch December 20, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.21 breaks support for host: "*.my.com"
5 participants