Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate alternative backend merging #3635

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

wayt
Copy link
Contributor

@wayt wayt commented Jan 8, 2019

What this PR does / why we need it:
When there are multiple locations per server, where each location is configured to point to the same server/backend, ingress-nginx will merge alternative backend into the main one repeatedly.

Ex:

  {
    "name": "web-app-80",
    "service": {
      "metadata": {
        "creationTimestamp": null
      },

...

    "noServer": false,
    "trafficShapingPolicy": {
      "weight": 0,
      "header": "",
      "cookie": ""
    },
    "alternativeBackends": [
      "web-canary-app-80",
      "web-canary-app-80",
      "web-canary-app-80"
    ]
  },

Here, web-canary-app-80 gets merged 3 times while having 3 ingresses with different locations. All pointing to the same server web-app.

This causes no real issue for now but is definitely incorrect.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Test in controller_test.go TestMergeAlternativeBackends for this are irrelevant because ingress.Backend.Equal does not check for a duplicate value https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/types_equals.go#L182

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2019
@wayt
Copy link
Contributor Author

wayt commented Jan 8, 2019

/assign @ElvinEfendi

@ElvinEfendi
Copy link
Member

/approve

I'll let @aledbf lgtm so that he can also take another look.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@aledbf
Copy link
Member

aledbf commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi, wayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47addbb into kubernetes:master Jan 8, 2019
@wayt wayt deleted the alternative-backend-merge branch January 8, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants