Fix duplicate alternative backend merging #3635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When there are multiple locations per server, where each location is configured to point to the same server/backend, ingress-nginx will merge alternative backend into the main one repeatedly.
Ex:
Here,
web-canary-app-80
gets merged 3 times while having 3 ingresses with different locations. All pointing to the same serverweb-app
.This causes no real issue for now but is definitely incorrect.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Test in
controller_test.go
TestMergeAlternativeBackends
for this are irrelevant becauseingress.Backend.Equal
does not check for a duplicate value https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/types_equals.go#L182