Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy_ssl_* directives #4327

Merged
merged 4 commits into from
Aug 18, 2019
Merged

Add proxy_ssl_* directives #4327

merged 4 commits into from
Aug 18, 2019

Conversation

leki75
Copy link
Contributor

@leki75 leki75 commented Jul 18, 2019

What this PR does / why we need it:
Add support for backends which require certificate authentication (eg. NiFi). The proxy-ssl-secret k8s annotation references a secret which is used to authenticate to the backend server. All other directives fine-tune backend communication.

Special notes for your reviewer:
The following annotations are supported:

  • proxy-ssl-secret
  • proxy-ssl-ciphers
  • proxy-ssl-protocol
  • proxy-ssl-verify
  • proxy-ssl-verify-depth

@leki75
Add proxy_ssl_* directives
def13fc 
Add support for backends which require client certificate (eg. NiFi)
authentication. The `proxy-ssl-secret` k8s annotation references a
secret which is used to authenticate to the backend server. All other
directives fine tune the backend communication.

The following annotations are supported:
* proxy-ssl-secret
* proxy-ssl-ciphers
* proxy-ssl-protocol
* proxy-ssl-verify
* proxy-ssl-verify-depth
@k8s-ci-robot
Copy link
Contributor

Welcome @leki75!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @leki75. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2019
@leki75
Copy link
Contributor Author

leki75 commented Jul 18, 2019

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Jul 18, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@aledbf
Copy link
Member

aledbf commented Jul 18, 2019

/test pull-ingress-nginx-test

@codecov-io
Copy link

codecov-io commented Jul 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f0383c6). Click here to learn what that means.
The diff coverage is 87.32%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4327   +/-   ##
=========================================
  Coverage          ?   59.09%           
=========================================
  Files             ?       89           
  Lines             ?     6930           
  Branches          ?        0           
=========================================
  Hits              ?     4095           
  Misses            ?     2402           
  Partials          ?      433
Impacted Files Coverage Δ
internal/ingress/types.go 0% <ø> (ø)
internal/ingress/annotations/annotations.go 81.69% <100%> (ø)
internal/ingress/controller/store/store.go 60.31% <100%> (ø)
internal/ingress/controller/controller.go 46.97% <25%> (ø)
internal/ingress/annotations/proxyssl/main.go 95.08% <95.08%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0383c6...4624b5b. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 31, 2019

@leki75 please add e2e tests

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2019
@leki75
Copy link
Contributor Author

leki75 commented Aug 14, 2019

Added end-to-end test

@leki75
Copy link
Contributor Author

leki75 commented Aug 14, 2019

/test pull-ingress-nginx-test

@leki75
Copy link
Contributor Author

leki75 commented Aug 14, 2019

/test pull-ingress-nginx-e2e-1-12

@leki75
Copy link
Contributor Author

leki75 commented Aug 14, 2019

/test pull-ingress-nginx-lualint

@leki75
Copy link
Contributor Author

leki75 commented Aug 14, 2019

/test pull-ingress-nginx-test-lua

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

@leki75 thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/retest

@aledbf aledbf removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@leki75
Copy link
Contributor Author

leki75 commented Aug 16, 2019

/retest

@ElvinEfendi
Copy link
Member

/lgtm

It'd be great to have configmap counterparts of these annotations.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi, leki75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 75d65bb into kubernetes:master Aug 18, 2019
@leki75 leki75 deleted the proxyssl branch August 20, 2019 10:58
This was referenced Aug 27, 2019
Closed
Closed
@aledbf aledbf mentioned this pull request Oct 1, 2019
Closed
@aledbf aledbf mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@aledbf aledbf

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leki75 @k8s-ci-robot @aledbf @codecov-io @ElvinEfendi