-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add Support for Wildcard Hosts with Sticky Sessions #4478
Conversation
Welcome @zikhan! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @zikhan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4478 +/- ##
=========================================
Coverage ? 59.27%
=========================================
Files ? 89
Lines ? 6773
Branches ? 0
=========================================
Hits ? 4015
Misses ? 2331
Partials ? 427 Continue to review full report at Codecov.
|
/test pull-ingress-nginx-e2e-1-12 |
/retest |
@@ -105,6 +105,16 @@ end | |||
local function should_set_cookie(self) | |||
if self.cookie_session_affinity.locations then | |||
local locs = self.cookie_session_affinity.locations[ngx.var.host] | |||
if locs == nil then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make sure ngx.var.host
exist here:
if locs == nil and ngx.var.host ~= nil then ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make more sense to move it up to the first if
statement (line 106)?
Because wouldn't
local locs = self.cookie_session_affinity.locations[nil]
always return locs = nil?
38e2059
to
84cbec0
Compare
84cbec0
to
76c2063
Compare
/test pull-ingress-nginx-codegen |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, zikhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Prior to #3383 (0.21), Sticky Sessions worked with any valid host in the ingress spec due to the balancer implementation literally just setting the cookie and moving on. This is to add that functionality back in. A spec was created for the Kubernetes Ingress spec to support it.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3534Special notes for your reviewer: I took inspiration from the discussion that occurred in #3534.