Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set mirror source when a target is configured #5055

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 11, 2020

What this PR does / why we need it:

mirror locations should be defined only when the annotation is used and contains a valid target.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #5055 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5055      +/-   ##
==========================================
- Coverage   58.49%   58.47%   -0.03%     
==========================================
  Files          88       88              
  Lines        6865     6866       +1     
==========================================
- Hits         4016     4015       -1     
- Misses       2409     2410       +1     
- Partials      440      441       +1
Impacted Files Coverage Δ
internal/ingress/annotations/mirror/main.go 53.84% <100%> (+1.84%) ⬆️
internal/ingress/annotations/authreq/main.go 73.1% <0%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc41dc7...e857e6c. Read the comment docs.

@aledbf aledbf merged commit 281139d into kubernetes:master Feb 11, 2020
@aledbf aledbf deleted the fix-mirror branch February 12, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants