-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label selector for plugin #5080
Conversation
Welcome @aca! |
Hi @aca. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@aca thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aca, aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #5080 +/- ##
=========================================
+ Coverage 58.5% 59.2% +0.69%
=========================================
Files 88 88
Lines 6866 7143 +277
=========================================
+ Hits 4017 4229 +212
- Misses 2409 2463 +54
- Partials 440 451 +11
Continue to review full report at Codecov.
|
What this PR does / why we need it:
fix #4950
Nginx-ingress-controller is often deployed as daemonset. Current implementation only supports pod / deployment options. It will be much flexible if we can use label selector for controller.
Types of changes
Which issue/s this PR fixes
#4950
Checklist: