Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label selector for plugin #5080

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add label selector for plugin #5080

merged 1 commit into from
Feb 21, 2020

Conversation

aca
Copy link
Contributor

@aca aca commented Feb 15, 2020

What this PR does / why we need it:

fix #4950
Nginx-ingress-controller is often deployed as daemonset. Current implementation only supports pod / deployment options. It will be much flexible if we can use label selector for controller.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

#4950

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @aca!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @aca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2020
@aledbf
Copy link
Member

aledbf commented Feb 15, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2020
@aledbf
Copy link
Member

aledbf commented Feb 21, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2020
@aledbf
Copy link
Member

aledbf commented Feb 21, 2020

@aca thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aca, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@aledbf
Copy link
Member

aledbf commented Feb 21, 2020

/retest

2 similar comments
@aledbf
Copy link
Member

aledbf commented Feb 21, 2020

/retest

@aledbf
Copy link
Member

aledbf commented Feb 21, 2020

/retest

@codecov-io
Copy link

Codecov Report

Merging #5080 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5080      +/-   ##
=========================================
+ Coverage    58.5%   59.2%   +0.69%     
=========================================
  Files          88      88              
  Lines        6866    7143     +277     
=========================================
+ Hits         4017    4229     +212     
- Misses       2409    2463      +54     
- Partials      440     451      +11
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 88.54% <0%> (-2.09%) ⬇️
internal/ingress/controller/endpoints.go 93.33% <0%> (-0.42%) ⬇️
internal/ingress/controller/controller.go 53.04% <0%> (+3.1%) ⬆️
internal/ingress/controller/store/store.go 62.6% <0%> (+5.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010563d...b096bf9. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 0d02ec2 into kubernetes:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl plugin: allow label based selector for pods
4 participants