-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add case for when user agent is nil #5091
Add case for when user agent is nil #5091
Conversation
Hi @BrianKopp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #5091 +/- ##
=========================================
Coverage ? 58.68%
=========================================
Files ? 88
Lines ? 6850
Branches ? 0
=========================================
Hits ? 4020
Misses ? 2390
Partials ? 440 Continue to review full report at Codecov.
|
Add test for nil user agent
3cd00da
to
b2beeea
Compare
/lgtm |
@BrianKopp thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, BrianKopp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This PR simply adds a check to protect against a nil user agent in the same site tests, as pointed out here.
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: