Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom healthz path in helm chart #5251

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Add support for custom healthz path in helm chart #5251

merged 1 commit into from
Mar 16, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 15, 2020 •
edited
Loading

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

xref: #5161

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2020
@aledbf
Copy link
Member Author

aledbf commented Mar 15, 2020

/assign @ChiefAlexander

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2020
@aledbf aledbf force-pushed the healthz branch 2 times, most recently from c5a2bd3 to 9be154d Compare March 15, 2020 15:44
@ChiefAlexander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9360244 into kubernetes:master Mar 16, 2020
@aledbf aledbf deleted the healthz branch March 16, 2020 18:53
sslavic
sslavic reviewed Jun 23, 2020
View reviewed changes
charts/ingress-nginx/values.yaml
@@ -212,6 +212,10 @@ controller:
timeoutSeconds: 1
port: 10254

# Path of the health check endpoint. All requests received on the port defined by
# the healthz-port parameter are forwarded internally to this path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf both controller.healthCheckPath documentation in charts/ingress-nginx/README.md and here reference healthz-port parameter. I can see controller.readinessProbe.port and controller.livenessProbe.port, but I cannot find one named healthz-port. Can you please clarify, is healthz-port reference just a generic term for the other two, or is healthz-port actual parameter somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sslavic are deployment flags https://kubernetes.github.io/ingress-nginx/user-guide/cli-arguments/
--health-check-path
--healthz-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslavic sslavic sslavic left review comments

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@ChiefAlexander ChiefAlexander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @ChiefAlexander @k8s-ci-robot @sslavic