Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to generate yaml files from helm #5313

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Add script to generate yaml files from helm #5313

merged 1 commit into from
Apr 6, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 1, 2020 •
edited
Loading

What this PR does / why we need it:

Use helm to generate yaml manifests to install the ingress controller in different scenarios. The same helm command definition will be used to update the docs presenting the option to use a static yaml file or helm.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

xref: #5161

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@aledbf aledbf mentioned this pull request Apr 1, 2020
Closed
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2020
@aledbf aledbf force-pushed the deployhelm branch 6 times, most recently from 4fd7e40 to c0ba710 Compare April 2, 2020 21:04
This was referenced Apr 2, 2020
Closed
Closed
Closed
Closed
@aledbf aledbf force-pushed the deployhelm branch 2 times, most recently from b7fa418 to d2918f0 Compare April 2, 2020 23:43
@aledbf aledbf changed the title WIP: Add script to generate yaml files from helm Add script to generate yaml files from helm Apr 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2020
@aledbf aledbf merged commit 42fcc07 into kubernetes:master Apr 6, 2020
@aledbf aledbf deleted the deployhelm branch April 6, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledbf @k8s-ci-robot