Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multi-arch images by default #5629

Merged
merged 1 commit into from
May 31, 2020
Merged

Build multi-arch images by default #5629

merged 1 commit into from
May 31, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 31, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2020
@aledbf
Copy link
Member Author

aledbf commented May 31, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #5629 into master will decrease coverage by 0.06%.
The diff coverage is 39.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5629      +/-   ##
==========================================
- Coverage   58.54%   58.48%   -0.07%     
==========================================
  Files          88       88              
  Lines        6950     6975      +25     
==========================================
+ Hits         4069     4079      +10     
- Misses       2432     2446      +14     
- Partials      449      450       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 5.61% <0.00%> (-0.38%) ⬇️
...ternal/ingress/annotations/sessionaffinity/main.go 60.41% <ø> (+1.59%) ⬆️
internal/ingress/controller/template/template.go 79.67% <0.00%> (ø)
internal/ingress/types.go 0.00% <ø> (ø)
internal/ingress/types_equals.go 17.09% <0.00%> (-0.10%) ⬇️
internal/ingress/controller/controller.go 49.59% <42.85%> (-0.06%) ⬇️
internal/ingress/annotations/annotations.go 81.69% <100.00%> (ø)
internal/ingress/annotations/sslcipher/main.go 100.00% <100.00%> (ø)
internal/task/queue.go 77.92% <0.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f20548...a02b4d4. Read the comment docs.

@aledbf aledbf force-pushed the ref branch 2 times, most recently from db9dc8a to 15be87e Compare May 31, 2020 15:15
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2020
@aledbf
Copy link
Member Author

aledbf commented May 31, 2020

/test pull-ingress-nginx-e2e-1-17

@aledbf
Copy link
Member Author

aledbf commented May 31, 2020

/test pull-ingress-nginx-e2e-1-16

@aledbf
Copy link
Member Author

aledbf commented May 31, 2020

/test pull-ingress-nginx-e2e-1-15

@aledbf
Copy link
Member Author

aledbf commented May 31, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2020
@aledbf aledbf merged commit d250b97 into kubernetes:master May 31, 2020
@aledbf aledbf deleted the ref branch May 31, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants