-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes for nginx-ingress chart for better keel and prom-oper #6104
Conversation
…rator integration
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @phntom! |
Hi @phntom. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rator integration Update: allow values.yaml without labels to pass
I signed it |
charts/ingress-nginx/Chart.yaml
Outdated
@@ -1,6 +1,6 @@ | |||
apiVersion: v1 | |||
name: ingress-nginx | |||
version: 2.13.0 | |||
version: 2.13.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is adding new functionality let's bump the minor version:
version: 2.13.1 | |
version: 2.14.0 |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, phntom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ability to add labels to controller deployment for keel.sh and 2 useful alerts
What this PR does / why we need it:
keel.sh labels integration
useful prometheus operator alertmanager alerts
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
==> Linting ingress-nginx
1 chart(s) linted, 0 chart(s) failed
helm install'ed on EKS and Linode with prometheus-operator and kee.sh installed.
examples of usage provided as comments next to changed sections in values.yaml
Checklist: