Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLBC] Set Description field for backend services #681

Merged
merged 2 commits into from
May 5, 2017
Merged

[GLBC] Set Description field for backend services #681

merged 2 commits into from
May 5, 2017

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented May 3, 2017 •
edited
Loading

Setting the backend service description field with the service's namespace, name, port, and protocol.

GCP Console

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@nicksardo nicksardo requested a review from bowei May 3, 2017 00:37
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 47.131% when pulling 22cdd7e on nicksardo:gce-bs-description into f9663a8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 47.139% when pulling 377d371 on nicksardo:gce-bs-description into f9663a8 on kubernetes:master.

@bowei
Copy link
Member

bowei commented May 5, 2017

LGTM

@nicksardo nicksardo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2017
@nicksardo nicksardo merged commit 4601775 into kubernetes:master May 5, 2017
@nicksardo nicksardo deleted the gce-bs-description branch May 5, 2017 18:34
@nicksardo nicksardo mentioned this pull request May 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @k8s-reviewable @coveralls @bowei @k8s-ci-robot