-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relabelings in controller-servicemonitor.yaml #8008
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @danksim! |
Hi @danksim. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@danksim please sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please bump the chart version and add an entry in the changelog
thanks for this PR 🎉
Thanks. I have addressed your comment and just signed the CLA, could you kindly confirm? Looks like the |
we are still required to sign the other CLA as well, the new CLA is not fully migrated |
/triage accepted |
/check-cla |
/check-cla |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for ci |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, danksim, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add relabelings above metricRelabelings in controller-servicemonitor.yaml * Bump chart version to 4.0.13, Add to CHANGELOG * Rename PR/CHANGELOG
In order to drop metrics before ingestion, I need to utilize
relabelings
(before ingestion), notmetricRelabelings
(after ingestion)What this PR does / why we need it:
There were no ways to modify
relabeings
in the helm manifest before this PRTypes of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: