Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote states access for k8s-infra-oncall #1681

Closed
ameukam opened this issue Feb 19, 2021 · 10 comments
Closed

Remote states access for k8s-infra-oncall #1681

ameukam opened this issue Feb 19, 2021 · 10 comments
Assignees
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@ameukam
Copy link
Member

ameukam commented Feb 19, 2021

Members of k8s-infra-oncall@kubernetes.io should be able to apply Terraform changes once there are merged. This is not currently the case.
They'll need write access to the bucket k8s-infra-clusters-terraform so they can push modified state to the remote backend when they run terraform apply.

/area access
/priority backlog
/wg k8s-infra
/assign @spiffxp @thockin

@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 19, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2021

Good point! Thank you for bumping into this.

I think it would be cleaner if we used a different bucket.

This way we can use iam at the bucket level, instead of per-object ACLs, to ensure that k8s-infra-prow-oncall doesn't accidentally blow away the aaa cluster

@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2021

/remove-priority backlog
/priority important-soon
/sig testing
/area prow
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 19, 2021
@thockin
Copy link
Member

thockin commented Feb 19, 2021

Aaron: "different" from what?

Agree with the goal, though

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2021

Different from using gs://k8s-infra-clusters-terraform as a catchall bucket.

Within kubernetes-public

  • gs://k8s-infra-terraform-prow
  • gs://k8s-infra-terraform-aaa (or org, or something)

Trying to think toward what this would look like if we started moving projects into folders within the org, and granting permissions within those folders.

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2021

Similar issue: my non-org-admin k8s-infra-prow-oncall account can't actually run ./infra/gcp/prow/ensure-e2e-projects.sh

Ensuring e2e projects exist and are appropriately configured
  Ensuring e2e project exists and is appropriately configured: k8s-infra-e2e-gce-project
    ERROR: (gcloud.beta.billing.projects.link) User [spiffxp@gmail.com] does not have permission to access projects instance [k8s-infra-e2e-gce-project] (or it may not exist): The caller does not have permission

(I'll break this out, this issue should be kept to terraform, but that's the direction I'm headed)

@ameukam
Copy link
Member Author

ameukam commented Apr 16, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Apr 16, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2021
@ameukam
Copy link
Member Author

ameukam commented Jul 21, 2021

Some progress were made by @spiffxp since the issue is open. See #1743 for more details

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 21, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 27, 2021

/close
#1952 setup separate GCS buckets for different groupings of terraform resources, one of which was gs://k8s-infra-tf-prow-clusters, which k8s-infra-prow-oncall@kubernetes.io has full access to. I think that fits the scope of this issue

I'll use a separate issue to keep track of "must be able to run ensure-e2e-projects.sh"

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
#1952 setup separate GCS buckets for different groupings of terraform resources, one of which was gs://k8s-infra-tf-prow-clusters, which k8s-infra-prow-oncall@kubernetes.io has full access to. I think that fits the scope of this issue

I'll use a separate issue to keep track of "must be able to run ensure-e2e-projects.sh"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants