Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup gcb-builder-releng-test SA for k8s-infra-prow-build #1626

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Feb 9, 2021

This redoes #1620 to support kubernetes/release#1850

Try to converge on a consistent naming pattern:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021
Try to converge on a consistent naming pattern:
- k8s-infra-staging-foo@kubernetes.io group
- k8s-staging-foo project
- gcb-builder-foo service account in k8s-staging-foo project
- gcb-builder-foo service account usable by prow
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2021
@spiffxp spiffxp force-pushed the gcb-builder-releng-test branch from d74d6a9 to 2251314 Compare February 9, 2021 00:30
@spiffxp
Copy link
Member Author

spiffxp commented Feb 9, 2021

/assign @cpanato
/cc @hasheddan @justaugustus
I have already actuated the changes here, with the exception of deploying the service account resource to k8s-infra-prow-build. That will happen automatically when this PR merges.

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spiffxp !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Base automatically changed from master to main February 9, 2021 00:35
@k8s-ci-robot k8s-ci-robot merged commit a8e0b65 into kubernetes:main Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 9, 2021
@spiffxp spiffxp deleted the gcb-builder-releng-test branch February 9, 2021 00:44
@spiffxp
Copy link
Member Author

spiffxp commented Feb 9, 2021

Can verify whether this works as expected once kubernetes/test-infra#20703 (review) is addressed and the PR merged

@cpanato
Copy link
Member

cpanato commented Feb 9, 2021

hum, thanks! learning new things!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants