Add ensure-organization.sh, give prow-oncall org browse access #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is intended to setup org-level resources - the bindings already exist, I dropped TODOs in places where I think they could be refined - moved prow.viewer custom role creation here, dropped TODOs for the remaining custom roles
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/testing
k8s-ci-robot
requested review from
ameukam,
cjwagner and
hh
and removed request for
alejandrox1 and
xmudrii
This was referenced Feb 18, 2021
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
cjwagner
approved these changes
Feb 18, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/kind feature |
k8s-ci-robot
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678
Addresses part of #1659
Obviates #1648
I have already run this script and confirmed no changes, aside from the k8s-infra-prow-oncall@ binding
There are TODOs to address as followups, but I was motivated to close #1678 so will leave those for followup PRs