Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial-audit: k8s-staging-* update as of 2021-02-24 #1712

Merged
merged 1 commit into from
Mar 1, 2021
Merged

partial-audit: k8s-staging-* update as of 2021-02-24 #1712

merged 1 commit into from
Mar 1, 2021

Conversation

cncf-ci
Copy link
Contributor

@cncf-ci cncf-ci commented Feb 24, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2021
@cncf-ci cncf-ci changed the title audit: update as of 2021-02-24 partial-audit: kubernetes-staging-* update as of 2021-02-24 Feb 24, 2021
@cncf-ci cncf-ci changed the title partial-audit: kubernetes-staging-* update as of 2021-02-24 partial-audit: k8s-staging-* update as of 2021-02-24 Feb 24, 2021
@hh
Copy link
Member

hh commented Feb 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2021
spiffxp
spiffxp reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
A few things to fix in followup, but this generally looks good.

I'll see what I can do about the CLA while we wait for cncf-ci-robot to get it signed

audit/projects/k8s-staging-capi-docker/services/enabled.txt
@@ -1,11 +1,13 @@
NAME TITLE
cloudbuild.googleapis.com Cloud Build API
cloudkms.googleapis.com Cloud Key Management Service (KMS) API
compute.googleapis.com Compute Engine API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more APIs getting enabled that shouldn't be, I'm guessing this is one of the org admins migrating around on console...

...s-staging-e2e-test-images/buckets/artifacts.k8s-staging-e2e-test-images.appspot.com/iam.json
@@ -4,7 +4,8 @@
"members": [
"group:k8s-infra-artifact-admins@kubernetes.io",
"projectEditor:k8s-staging-e2e-test-images",
"projectOwner:k8s-staging-e2e-test-images"
"projectOwner:k8s-staging-e2e-test-images",
"serviceAccount:456067983721@cloudbuild.gserviceaccount.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs here, but I'll allow it for now.

Would like to revisit GCR and GCB permissions in general based on the auditing I was doing while troubleshooting in kubernetes/test-infra#20884 (comment)

audit/projects/k8s-staging-e2e-test-images/services/enabled.txt
logging.googleapis.com Cloud Logging API
monitoring.googleapis.com Cloud Monitoring API
oslogin.googleapis.com Cloud OS Login API
policytroubleshooter.googleapis.com Policy Troubleshooter API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was definitely me clicking around in gcp console while doing kubernetes/test-infra#20884 (comment)

nit for followup: can we consider dumping this in a format that doesn't change whitespace when services change?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2021 •
edited
Loading

/override cla/linuxfoundation
mmmm looks like I can't do that

This was referenced Feb 25, 2021
Closed
Closed
@hh
Copy link
Member

hh commented Mar 1, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 28299e7 into kubernetes:main Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@cncf-ci @k8s-ci-robot @hh @spiffxp