Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck warnings in verify-yamllint.sh #1733

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Feb 27, 2021

Fix somre warnings in hack/verify-yamllint.sh

/assign @spiffxp @BenTheElder

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Fix somre warnings in hack/verify-yamllint.sh

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/k8s-infra labels Feb 27, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Hopefully this doesn't force me to rebase 😄 (ref: d365faf)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3a1aea1 into kubernetes:main Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 27, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 27, 2021

yeah I had to rebase...

@BenTheElder
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants