Update k8s-infra-prow-build README to clarify access instructions. #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/testing
spiffxp
suggested changes
Feb 27, 2021
Comment on lines
9
to
16
| The k8s-infra-prow-build cluster is a [private GKE cluster](https://cloud.google.com/kubernetes-engine/docs/how-to/private-clusters). | ||
| It cannot be directly accessed with kubectl from outside the GCP project, | ||
| cloud-shell must first be used as follows: | ||
| ```shell | ||
| # Start a cloud shell | ||
| gcloud alpha cloud-shell ssh --project=k8s-infra-prow-build | ||
|
|
||
| # Login to set the authenticated user for gcloud in the cloud shell session. |
There was a problem hiding this comment.
As of #1727 this part is no longer true, so here's my suggestion to make this more relevant. Can move the bookmarks to the bottom of the page.
Suggested change
| The k8s-infra-prow-build cluster is a [private GKE cluster](https://cloud.google.com/kubernetes-engine/docs/how-to/private-clusters). | |
| It cannot be directly accessed with kubectl from outside the GCP project, | |
| cloud-shell must first be used as follows: | |
| ```shell | |
| # Start a cloud shell | |
| gcloud alpha cloud-shell ssh --project=k8s-infra-prow-build | |
| # Login to set the authenticated user for gcloud in the cloud shell session. | |
| Access to the [k8s-infra-prow-build project][k8s-infra-prow-build-console] hosting the cluster is granted by membership in one of two @kubernetes.io groups: | |
| - [k8s-infra-prow-oncall@kubernetes.io][k8s-infra-prow-oncall@]: grants [`roles/owner`][roles/owner] access | |
| - [k8s-infra-prow-viewers@kubernetes.io][k8s-infra-prow-viewers@]: grants [`prow.viewer`][roles/prow.viewer] access | |
| If you are not a member of either of these groups, please [follow these instructions to join][join-groups] | |
| [k8s-infra-prow-build-console]: https://console.cloud.google.com/home/dashboard?project=k8s-infra-prow-build | |
| [k8s-infra-prow-oncall]: https://github.com/kubernetes/k8s.io/blob/3a1aea1652f02a95253402bde2bca63cb4292f8e/groups/groups.yaml#L647-L670 | |
| [k8s-infra-prow-viewers]: https://github.com/kubernetes/k8s.io/blob/3a1aea1652f02a95253402bde2bca63cb4292f8e/groups/groups.yaml#L672-L699 | |
| [roles/owner]: https://cloud.google.com/iam/docs/understanding-roles#basic-definitions | |
| [roles/prow.viewer]: https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/roles/prow.viewer.yaml | |
| [join-groups]: https://github.com/kubernetes/k8s.io/tree/main/groups#making-changes | |
| ```shell | |
| # Login to set the authenticated user for gcloud |
There was a problem hiding this comment.
Awesome, added these changes.
cjwagner
force-pushed
the
accessing-k8s-infra
branch
from
b92ce51 to
7d341b1
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions for accessing the cluster were a bit hidden in the setup instructions. I pulled them out into their own section for clarity (and to link to more easily) and also fixed a minor mistake and an omission.
/assign @spiffxp