infra/gcp/prow: use two default ssh keys #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would rather just use the one, but I no longer have time to untangle whatever is going on between prow, kubetest2, cluster/log-dump.sh and `gcloud ssh` Since the steady state we've converged on is most projects having both keys, make that the default / expected state
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
sig/testing
spiffxp
force-pushed
the
default-multiple-e2e-ssh-keys
branch
from
712053a to
8da8aa9
Compare
k8s-ci-robot
added
size/S
spiffxp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
OK, removed [wip] commit 712053a Ran
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ameukam
reviewed
Apr 9, 2021
| fi | ||
|
|
||
| if ! diff ${ssh_keys_before} ${ssh_keys_after} >/dev/null; then | ||
| gcloud compute project-info add-metadata --project="${prj}" \ | ||
| cloud compute project-info add-metadata --project="${prj}" \ |
|
/lgtm late :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup to #1894
Fixes #1751
I would rather just use the one, but I no longer have time to untangle whatever is going on between prow, kubetest2, cluster/log-dump.sh and
gcloud ssh(ref: #1751 (comment))Since the steady state we've converged on is most projects having both keys, make that the default / expected state
As with #1894 I've added a [wip] commit to this PR to make running this script faster. Will remove commit and [wip] from PR once actuated.