-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps/cert-manager: match what is deployed #2380
apps/cert-manager: match what is deployed #2380
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@jimdaga: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
I'm willing to sponsor you as an org member if you're interested, ref: https://github.com/kubernetes/community/blob/master/community-membership.md#member |
That would be great! thank you! I'll start to review that I have everything in order. |
Followup to #2374
Update the deploy.sh script to assume the resources have the correct namespace defined within them
Update letsencrypt-prod to match what I found in production. It might be wrong! But if it's been there this long without complaint, I don't want to change it just because we're shuffling an app's resource files around.