Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/cert-manager: match what is deployed #2380

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 21, 2021

Followup to #2374

Update the deploy.sh script to assume the resources have the correct namespace defined within them

Update letsencrypt-prod to match what I found in production. It might be wrong! But if it's been there this long without complaint, I don't want to change it just because we're shuffling an app's resource files around.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ixdy and munnerz July 21, 2021 17:16
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 21, 2021

/cc @ameukam
FYI @jimdaga

@k8s-ci-robot k8s-ci-robot requested a review from ameukam July 21, 2021 17:21
@jimdaga
Copy link

jimdaga commented Jul 21, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jimdaga: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member

ameukam commented Jul 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit ce98a2b into kubernetes:main Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 21, 2021
@spiffxp spiffxp deleted the cert-manager-as-deployed branch July 21, 2021 17:36
@spiffxp
Copy link
Member Author

spiffxp commented Jul 21, 2021

@jimdaga
Copy link

jimdaga commented Jul 21, 2021

@jimdaga: changing LGTM is restricted to collaborators

https://github.com/issues?q=author%3Ajimdaga+archived%3Afalse+sort%3Aupdated-desc+org%3Akubernetes+

I'm willing to sponsor you as an org member if you're interested, ref: https://github.com/kubernetes/community/blob/master/community-membership.md#member

That would be great! thank you! I'll start to review that I have everything in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/cert-manager cert-manager, code in apps/cert-manager/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants