Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifacts: Add docs for file/artifact promotion #2711

Merged
merged 1 commit into from
Sep 14, 2021
Merged

artifacts: Add docs for file/artifact promotion #2711

merged 1 commit into from
Sep 14, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 13, 2021 •
edited
Loading

(Part of #2624, kubernetes-sigs/promo-tools#413.)
Supports #2272.

Signed-off-by: Stephen Augustus foo@auggie.dev

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ labels Sep 13, 2021
@justaugustus justaugustus changed the title [WIP] artifacts: Add docs for file/artifact promotion artifacts: Add docs for file/artifact promotion Sep 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2021
@justaugustus
Copy link
Member Author

/assign @ameukam @spiffxp @dims @justinsb
/cc @puerco @cpanato @Verolop @saschagrunert @jingxu97
cc: @kubernetes-sigs/release-engineering @kubernetes/k8s-infra-group-admins @kubernetes/wg-k8s-infra-leads

@justaugustus justaugustus mentioned this pull request Sep 13, 2021
Closed
ameukam
ameukam reviewed Sep 13, 2021
View reviewed changes
artifacts/README.md Outdated Show resolved Hide resolved
@ameukam
Copy link
Member

ameukam commented Sep 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
cpanato
cpanato approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2021
@justaugustus
artifacts: Add docs for file/artifact promotion
034ffc9 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 13, 2021
@dims
Copy link
Member

dims commented Sep 13, 2021

/approve

leaving /lgtm for a sig-release reviewer.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@puerco
Copy link
Member

puerco commented Sep 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit b0194dd into kubernetes:main Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 14, 2021
@justaugustus justaugustus mentioned this pull request Sep 22, 2021
Merged
@jingxu97 jingxu97 mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@cpanato cpanato cpanato approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

@thockin thockin Awaiting requested review from thockin

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@puerco puerco Awaiting requested review from puerco

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@dims dims

@spiffxp spiffxp

@justinsb justinsb

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @ameukam @dims @k8s-ci-robot @puerco @cpanato @spiffxp @justinsb