Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give kustomize owners key encryption permission #2805

Merged
merged 1 commit into from
Sep 24, 2021
Merged

give kustomize owners key encryption permission #2805

merged 1 commit into from
Sep 24, 2021

Conversation

natasha41575
Copy link
Contributor

Discovered that we need one more permission (cloudkms.cryptoKeyVersions.useToEncrypt)

/cc @KnVerey @monopole @spiffxp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 24, 2021
spiffxp
spiffxp approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86b2c9e into kubernetes:main Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp
Copy link
Member

spiffxp commented Sep 24, 2021

Ran ensure-staging-storage.sh kustomize

@natasha41575
Copy link
Contributor Author

Thank you!!

@spiffxp spiffxp mentioned this pull request Sep 24, 2021
Merged
@natasha41575 natasha41575 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@KnVerey KnVerey Awaiting requested review from KnVerey

@monopole monopole Awaiting requested review from monopole

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@natasha41575 @k8s-ci-robot @spiffxp