Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash/staging: prune unexpected services #2813

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 24, 2021

Related:

Specifically

  • add a mechanism for staging projects to specify special case services
    that they expect to have enabled
  • use that mechanism for cluster-api-gcp and sig-storage
  • set obnoxious env var that causes ensure_only_services to disable any
    service not explicitly requested as enabled
  • cleanup: order special case functions by project name

Last step before I call #1675
done will be to run ensure-staging-storage.sh for all staging projects
just to ensure we've pruned all unexpected services.

Specifically

- add a mechanism for staging projects to specify special case services
  that they expect to have enabled
- use that mechanism for cluster-api-gcp and sig-storage
- set obnoxious env var that causes ensure_only_services to disable any
  service not explicitly requested as enabled
- cleanup: order special case functions by project name
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ labels Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

I've run ensure-staging-storage.sh cluster-api-gcp and ensure-staging-storage.sh kubetest2 to ensure this works for both projects that have a stock set of services, and projects that have additional services enabled as a special case.

@ameukam
Copy link
Member

ameukam commented Sep 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4fba6dd into kubernetes:main Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp spiffxp deleted the staging-special-case-services branch September 24, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants