-
Notifications
You must be signed in to change notification settings - Fork 876
terraform/k8s-infra-prow-build: add dashboards #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform/k8s-infra-prow-build: add dashboards #2938
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/uncc @e-blackwelder @michelle192837 /cc @cjwagner @chaodaiG |
/hold |
@cjwagner and I were discussing about this, mainly around whether to source control dashboard(s) or not. For us it's still at exploratory state, so we might not want to source control the exported json file, at least not at this time, on the other hand we are not seeing any one manually editing this json for dashboard changes. The main reason for exporting the json, is for serving the purpose of rolling it back and being able to track history. So alternatively we are considering automating the json export to GCS, which we'll be using a versioned blob so that we can track history. The automation can potentially be done by a periodic prow job, or even Cloud Run etc. |
I don't have a strong preference for the moment. I think I want some answers to the meta-questions (#2588) related to k8s-infra monitoring before we decide what's the correct way to handle monitoring dashboards. /lgtm |
/hold cancel |
for f in dashboards/*.json; do
echo $f;
file=$(basename $f);
name=$(<$f jq -r .name);
terraform import google_monitoring_dashboard.dashboards[\"$file\"] $name;
done |
Related:
I added these to the k8s-infra-prow-build terraform module since it's been handling everything for this GCP project. I'm happy to move to the k8s-infra-monitoring module if that's your preference @ameukam
Actually "deploying" this is going to require a terraform import since the dashboards already exist (these were copied out of audit and piped through jq for legibility)