Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap GCP sandbox infrastructure for archeio #3318

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Bootstrap GCP sandbox infrastructure for archeio #3318

merged 2 commits into from
Jan 28, 2022

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jan 28, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jan 28, 2022
@ameukam
Copy link
Member Author

ameukam commented Jan 28, 2022

cc @BenTheElder @dims

The Terraform part is already deployed.

@ameukam
Bootstrap GCP sandbox infrastructure for archeio
cef04d0 
Related:
 - kubernetes#3317

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
DNS: add A and AAAA records for registry-sandbox.k8s.io
28c49cb 
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@dims
Copy link
Member

dims commented Jan 28, 2022

@ameukam looks like we need to fix the verify?

�[0;31mFAILED�[0m   verify-boilerplate.sh	0s

@ameukam
Copy link
Member Author

ameukam commented Jan 28, 2022

@dims Fixed.

@dims
Copy link
Member

dims commented Jan 28, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9bb1306 into kubernetes:main Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 28, 2022
@ameukam ameukam mentioned this pull request Jan 28, 2022
Merged
@BenTheElder BenTheElder mentioned this pull request Jan 28, 2022
Closed
@ameukam ameukam mentioned this pull request Jan 30, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @dims @k8s-ci-robot