Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL redirection from "k8s.io/internal" as experiment #3355

Closed
wants to merge 1 commit into from
Closed

URL redirection from "k8s.io/internal" as experiment #3355

wants to merge 1 commit into from

Conversation

dims
Copy link
Member

@dims dims commented Feb 4, 2022 •
edited
Loading

Context in #3307

Signed-off-by: Davanum Srinivas davanum@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and spiffxp February 4, 2022 16:45
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 4, 2022
thockin
thockin reviewed Feb 4, 2022
View reviewed changes
apps/k8s-io/configmap-nginx.yaml Outdated Show resolved Hide resolved
apps/k8s-io/configmap-nginx.yaml Outdated Show resolved Hide resolved
@dims
URL redirection from "k8s.io/internal" as experiment
a75d64e 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the url-redirection-from-k8s.io/internal-as-experiment branch from 258d897 to a75d64e Compare February 4, 2022 18:26
@thockin
Copy link
Member

thockin commented Feb 4, 2022

That looks more likely to work. Happy canarying ! :)

@dims
Copy link
Member Author

dims commented Feb 4, 2022

ack will try canarying later today. gotta run an errand. thanks @thockin

@dims
Copy link
Member Author

dims commented Feb 4, 2022

canary looks good!

davanum@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ curl -i -k -H hostname=k8s.io 'https://34.102.239.89/internal/foo/bar?go-get=1'
HTTP/2 200
server: nginx
date: Fri, 04 Feb 2022 22:39:15 GMT
content-type: text/plain
content-length: 584
via: 1.1 google
alt-svc: clear


            <html><head>
                  <meta name="go-import"
                        content="k8s.io/internal/foo
                                 git https://github.com/k8s-internal/foo">
                  <meta name="go-source"
                        content="k8s.io/internal/foo
                                 https://github.com/k8s-internal/foo
                                 https://github.com/k8s-internal/foo/tree/master{/dir}
                                 https://github.com/k8s-internal/foo/blob/master{/dir}/{file}#L{line}">
            </head></html>

@dims
Copy link
Member Author

dims commented Feb 4, 2022

the other redirect still works well

davanum@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ curl -i -k -H hostname=k8s.io 'https://34.102.239.89/foo/bar?go-get=1'
HTTP/2 200
server: nginx
date: Fri, 04 Feb 2022 22:38:31 GMT
content-type: text/plain
content-length: 558
via: 1.1 google
alt-svc: clear


            <html><head>
                  <meta name="go-import"
                        content="k8s.io/foo
                                 git https://github.com/kubernetes/foo">
                  <meta name="go-source"
                        content="k8s.io/foo
                                 https://github.com/kubernetes/foo
                                 https://github.com/kubernetes/foo/tree/master{/dir}
                                 https://github.com/kubernetes/foo/blob/master{/dir}/{file}#L{line}">
            </head></html>

@dims
Copy link
Member Author

dims commented Feb 5, 2022

YES!!!

davanum@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ ./deploy.sh prod
Deploying k8s-io to 'prod' target - ^C now to abort...
running kubectl apply...
configmap/nginx configured
configmap/www-get unchanged
deployment.apps/k8s-io configured
service/k8s-io unchanged
restarting deployment...
deployment.apps/k8s-io restarted
waiting for all replicas to be up...
  want 2, found 2 ready and 1 unavailable
  want 2, found 2 ready and 1 unavailable
  want 2, found 2 ready and 1 unavailable
  want 2, found 2 ready and 1 unavailable
Testing TARGET_IP=34.107.204.206
./test.py -q
TARGET_IP present in environment. Disabling SSL verification
GET http://get.k8s.io
GET http://get.kubernetes.io
GET https://get.k8s.io
GET https://get.kubernetes.io
GET https://k8s.io/example-repo/pkg/subpath?go-get=1
GET https://sigs.k8s.io/example-repo/pkg/subpath?go-get=1
REDIR: http://apt.k8s.io => https://packages.cloud.google.com/apt/
REDIR: https://apt.k8s.io => https://packages.cloud.google.com/apt/
REDIR: http://apt.k8s.io/7524 => https://packages.cloud.google.com/apt/7524
REDIR: https://apt.k8s.io/7524 => https://packages.cloud.google.com/apt/7524
REDIR: http://apt.kubernetes.io => https://packages.cloud.google.com/apt/
REDIR: https://apt.kubernetes.io => https://packages.cloud.google.com/apt/
REDIR: http://apt.kubernetes.io/2576 => https://packages.cloud.google.com/apt/2576
REDIR: https://apt.kubernetes.io/2576 => https://packages.cloud.google.com/apt/2576
REDIR: http://blog.k8s.io => https://kubernetes.io/blog/
REDIR: https://blog.k8s.io => https://kubernetes.io/blog/
REDIR: http://blog.k8s.io/8718 => https://kubernetes.io/blog/8718
REDIR: https://blog.k8s.io/8718 => https://kubernetes.io/blog/8718
REDIR: http://blog.kubernetes.io => https://kubernetes.io/blog/
REDIR: https://blog.kubernetes.io => https://kubernetes.io/blog/
REDIR: http://blog.kubernetes.io/9896 => https://kubernetes.io/blog/9896
REDIR: https://blog.kubernetes.io/9896 => https://kubernetes.io/blog/9896
REDIR: http://ci-test.kubernetes.io => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs
REDIR: https://ci-test.kubernetes.io => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs
REDIR: http://ci-test.kubernetes.io/ => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs
REDIR: https://ci-test.kubernetes.io/ => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs
REDIR: http://ci-test.kubernetes.io/e2e/ => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs/e2e
REDIR: https://ci-test.kubernetes.io/e2e/ => https://console.developers.google.com/storage/browser/kubernetes-jenkins/logs/e2e
REDIR: http://ci-test.kubernetes.io/e2e/5254/ => https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/e2e/5254
REDIR: https://ci-test.kubernetes.io/e2e/5254/ => https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/e2e/5254
REDIR: http://ci-test.kubernetes.io/e2e/5254 => https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/e2e/5254
REDIR: https://ci-test.kubernetes.io/e2e/5254 => https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/e2e/5254
REDIR: http://ci-test.kubernetes.io/e2e/5254/file => https://storage.cloud.google.com/kubernetes-jenkins/logs/e2e/5254/file
REDIR: https://ci-test.kubernetes.io/e2e/5254/file => https://storage.cloud.google.com/kubernetes-jenkins/logs/e2e/5254/file
REDIR: http://changelog.kubernetes.io => https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/README.md
REDIR: https://changelog.kubernetes.io => https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/README.md
REDIR: http://changelog.kubernetes.io/3741 => https://github.com/kubernetes/kubernetes/releases/tag/3741
REDIR: https://changelog.kubernetes.io/3741 => https://github.com/kubernetes/kubernetes/releases/tag/3741
REDIR: http://changelog.k8s.io => https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/README.md
REDIR: https://changelog.k8s.io => https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/README.md
REDIR: http://changelog.k8s.io/3741 => https://github.com/kubernetes/kubernetes/releases/tag/3741
REDIR: https://changelog.k8s.io/3741 => https://github.com/kubernetes/kubernetes/releases/tag/3741
REDIR: http://code.kubernetes.io/3741 => https://github.com/kubernetes/kubernetes/tree/master/3741
REDIR: https://code.kubernetes.io/3741 => https://github.com/kubernetes/kubernetes/tree/master/3741
REDIR: http://code.k8s.io/3741 => https://github.com/kubernetes/kubernetes/tree/master/3741
REDIR: https://code.k8s.io/3741 => https://github.com/kubernetes/kubernetes/tree/master/3741
REDIR: http://conduct.kubernetes.io/3612 => https://github.com/kubernetes/community/tree/master/committee-code-of-conduct/3612
REDIR: https://conduct.kubernetes.io/3612 => https://github.com/kubernetes/community/tree/master/committee-code-of-conduct/3612
REDIR: http://conduct.k8s.io/3612 => https://github.com/kubernetes/community/tree/master/committee-code-of-conduct/3612
REDIR: https://conduct.k8s.io/3612 => https://github.com/kubernetes/community/tree/master/committee-code-of-conduct/3612
REDIR: http://dl.k8s.io/v4474.4082.3831/9927 => https://storage.googleapis.com/kubernetes-release/release/v4474.4082.3831/9927
REDIR: https://dl.k8s.io/v4474.4082.3831/9927 => https://storage.googleapis.com/kubernetes-release/release/v4474.4082.3831/9927
REDIR: http://dl.k8s.io/v7694.3469.2815-alpha.4831/2982 => https://storage.googleapis.com/kubernetes-release/release/v7694.3469.2815-alpha.4831/2982
REDIR: https://dl.k8s.io/v7694.3469.2815-alpha.4831/2982 => https://storage.googleapis.com/kubernetes-release/release/v7694.3469.2815-alpha.4831/2982
REDIR: http://dl.k8s.io/v5540.9124.5849-beta.9956/5817 => https://storage.googleapis.com/kubernetes-release/release/v5540.9124.5849-beta.9956/5817
REDIR: https://dl.k8s.io/v5540.9124.5849-beta.9956/5817 => https://storage.googleapis.com/kubernetes-release/release/v5540.9124.5849-beta.9956/5817
REDIR: http://dl.k8s.io/v8864.6637.3803-rc.6728/1199 => https://storage.googleapis.com/kubernetes-release/release/v8864.6637.3803-rc.6728/1199
REDIR: https://dl.k8s.io/v8864.6637.3803-rc.6728/1199 => https://storage.googleapis.com/kubernetes-release/release/v8864.6637.3803-rc.6728/1199
REDIR: http://dl.k8s.io/v8/engine => https://storage.googleapis.com/kubernetes-release/v8/engine
REDIR: https://dl.k8s.io/v8/engine => https://storage.googleapis.com/kubernetes-release/v8/engine
REDIR: http://dl.k8s.io/v1.2.3-gamma.4/kubernetes.tar.gz => https://storage.googleapis.com/kubernetes-release/v1.2.3-gamma.4/kubernetes.tar.gz
REDIR: https://dl.k8s.io/v1.2.3-gamma.4/kubernetes.tar.gz => https://storage.googleapis.com/kubernetes-release/v1.2.3-gamma.4/kubernetes.tar.gz
REDIR: http://dl.k8s.io/ci/v8052/4860 => https://storage.googleapis.com/k8s-release-dev/ci/v8052/4860
REDIR: https://dl.k8s.io/ci/v8052/4860 => https://storage.googleapis.com/k8s-release-dev/ci/v8052/4860
REDIR: http://dl.k8s.io/ci/latest-4456.txt => https://storage.googleapis.com/k8s-release-dev/ci/latest-4456.txt
REDIR: https://dl.k8s.io/ci/latest-4456.txt => https://storage.googleapis.com/k8s-release-dev/ci/latest-4456.txt
REDIR: http://dl.k8s.io/3141 => https://storage.googleapis.com/kubernetes-release/3141
REDIR: https://dl.k8s.io/3141 => https://storage.googleapis.com/kubernetes-release/3141
REDIR: http://dl.kubernetes.io/v1008.5723.7485/3009 => https://storage.googleapis.com/kubernetes-release/release/v1008.5723.7485/3009
REDIR: https://dl.kubernetes.io/v1008.5723.7485/3009 => https://storage.googleapis.com/kubernetes-release/release/v1008.5723.7485/3009
REDIR: http://dl.kubernetes.io/v6421.1234.5723-alpha.4506/4009 => https://storage.googleapis.com/kubernetes-release/release/v6421.1234.5723-alpha.4506/4009
REDIR: https://dl.kubernetes.io/v6421.1234.5723-alpha.4506/4009 => https://storage.googleapis.com/kubernetes-release/release/v6421.1234.5723-alpha.4506/4009
REDIR: http://dl.kubernetes.io/v8027.1779.7126-beta.6687/5659 => https://storage.googleapis.com/kubernetes-release/release/v8027.1779.7126-beta.6687/5659
REDIR: https://dl.kubernetes.io/v8027.1779.7126-beta.6687/5659 => https://storage.googleapis.com/kubernetes-release/release/v8027.1779.7126-beta.6687/5659
REDIR: http://dl.kubernetes.io/v5648.3355.9796-rc.2395/3581 => https://storage.googleapis.com/kubernetes-release/release/v5648.3355.9796-rc.2395/3581
REDIR: https://dl.kubernetes.io/v5648.3355.9796-rc.2395/3581 => https://storage.googleapis.com/kubernetes-release/release/v5648.3355.9796-rc.2395/3581
REDIR: http://dl.kubernetes.io/v8/engine => https://storage.googleapis.com/kubernetes-release/v8/engine
REDIR: https://dl.kubernetes.io/v8/engine => https://storage.googleapis.com/kubernetes-release/v8/engine
REDIR: http://dl.kubernetes.io/v1.2.3-gamma.4/kubernetes.tar.gz => https://storage.googleapis.com/kubernetes-release/v1.2.3-gamma.4/kubernetes.tar.gz
REDIR: https://dl.kubernetes.io/v1.2.3-gamma.4/kubernetes.tar.gz => https://storage.googleapis.com/kubernetes-release/v1.2.3-gamma.4/kubernetes.tar.gz
REDIR: http://dl.kubernetes.io/ci/v5473/9223 => https://storage.googleapis.com/k8s-release-dev/ci/v5473/9223
REDIR: https://dl.kubernetes.io/ci/v5473/9223 => https://storage.googleapis.com/k8s-release-dev/ci/v5473/9223
REDIR: http://dl.kubernetes.io/ci/latest-8878.txt => https://storage.googleapis.com/k8s-release-dev/ci/latest-8878.txt
REDIR: https://dl.kubernetes.io/ci/latest-8878.txt => https://storage.googleapis.com/k8s-release-dev/ci/latest-8878.txt
REDIR: http://dl.kubernetes.io/8915 => https://storage.googleapis.com/kubernetes-release/8915
REDIR: https://dl.kubernetes.io/8915 => https://storage.googleapis.com/kubernetes-release/8915
REDIR: http://docs.k8s.io => https://kubernetes.io/docs/
REDIR: https://docs.k8s.io => https://kubernetes.io/docs/
REDIR: http://docs.k8s.io/v9160.6010 => https://kubernetes.io/docs
REDIR: https://docs.k8s.io/v9160.6010 => https://kubernetes.io/docs
REDIR: http://docs.k8s.io/v9160.6010/4937 => https://kubernetes.io/docs/4937
REDIR: https://docs.k8s.io/v9160.6010/4937 => https://kubernetes.io/docs/4937
REDIR: http://docs.k8s.io/4937 => https://kubernetes.io/docs/4937
REDIR: https://docs.k8s.io/4937 => https://kubernetes.io/docs/4937
REDIR: http://docs.kubernetes.io => https://kubernetes.io/docs/
REDIR: https://docs.kubernetes.io => https://kubernetes.io/docs/
REDIR: http://docs.kubernetes.io/v2950.3148 => https://kubernetes.io/docs
REDIR: https://docs.kubernetes.io/v2950.3148 => https://kubernetes.io/docs
REDIR: http://docs.kubernetes.io/v2950.3148/2617 => https://kubernetes.io/docs/2617
REDIR: https://docs.kubernetes.io/v2950.3148/2617 => https://kubernetes.io/docs/2617
REDIR: http://docs.kubernetes.io/2617 => https://kubernetes.io/docs/2617
REDIR: https://docs.kubernetes.io/2617 => https://kubernetes.io/docs/2617
REDIR: http://examples.k8s.io => https://github.com/kubernetes/examples/tree/master/
REDIR: https://examples.k8s.io => https://github.com/kubernetes/examples/tree/master/
REDIR: http://examples.k8s.io/ => https://github.com/kubernetes/examples/tree/master/
REDIR: https://examples.k8s.io/ => https://github.com/kubernetes/examples/tree/master/
REDIR: http://examples.k8s.io/v9644.6746 => https://github.com/kubernetes/kubernetes/tree/release-9644.6746/examples
REDIR: https://examples.k8s.io/v9644.6746 => https://github.com/kubernetes/kubernetes/tree/release-9644.6746/examples
REDIR: http://examples.k8s.io/v9644.6746/4726 => https://github.com/kubernetes/kubernetes/tree/release-9644.6746/examples/4726
REDIR: https://examples.k8s.io/v9644.6746/4726 => https://github.com/kubernetes/kubernetes/tree/release-9644.6746/examples/4726
REDIR: http://examples.kubernetes.io => https://github.com/kubernetes/examples/tree/master/
REDIR: https://examples.kubernetes.io => https://github.com/kubernetes/examples/tree/master/
REDIR: http://examples.kubernetes.io/ => https://github.com/kubernetes/examples/tree/master/
REDIR: https://examples.kubernetes.io/ => https://github.com/kubernetes/examples/tree/master/
REDIR: http://examples.kubernetes.io/v2761.5733 => https://github.com/kubernetes/kubernetes/tree/release-2761.5733/examples
REDIR: https://examples.kubernetes.io/v2761.5733 => https://github.com/kubernetes/kubernetes/tree/release-2761.5733/examples
REDIR: http://examples.kubernetes.io/v2761.5733/8509 => https://github.com/kubernetes/kubernetes/tree/release-2761.5733/examples/8509
REDIR: https://examples.kubernetes.io/v2761.5733/8509 => https://github.com/kubernetes/kubernetes/tree/release-2761.5733/examples/8509
REDIR: http://features.k8s.io => https://github.com/kubernetes/features/issues/
REDIR: https://features.k8s.io => https://github.com/kubernetes/features/issues/
REDIR: http://features.k8s.io/6629 => https://github.com/kubernetes/features/issues/6629
REDIR: https://features.k8s.io/6629 => https://github.com/kubernetes/features/issues/6629
REDIR: http://feature.k8s.io => https://github.com/kubernetes/features/issues/
REDIR: https://feature.k8s.io => https://github.com/kubernetes/features/issues/
REDIR: http://feature.k8s.io/4445 => https://github.com/kubernetes/features/issues/4445
REDIR: https://feature.k8s.io/4445 => https://github.com/kubernetes/features/issues/4445
REDIR: http://features.kubernetes.io => https://github.com/kubernetes/features/issues/
REDIR: https://features.kubernetes.io => https://github.com/kubernetes/features/issues/
REDIR: http://features.kubernetes.io/3035 => https://github.com/kubernetes/features/issues/3035
REDIR: https://features.kubernetes.io/3035 => https://github.com/kubernetes/features/issues/3035
REDIR: http://feature.kubernetes.io => https://github.com/kubernetes/features/issues/
REDIR: https://feature.kubernetes.io => https://github.com/kubernetes/features/issues/
REDIR: http://feature.kubernetes.io/6216 => https://github.com/kubernetes/features/issues/6216
REDIR: https://feature.kubernetes.io/6216 => https://github.com/kubernetes/features/issues/6216
REDIR: http://git.k8s.io => https://github.com/kubernetes/
REDIR: https://git.k8s.io => https://github.com/kubernetes/
REDIR: http://git.k8s.io/9474 => https://github.com/kubernetes/9474/
REDIR: https://git.k8s.io/9474 => https://github.com/kubernetes/9474/
REDIR: http://git.k8s.io/4025/ => https://github.com/kubernetes/4025/
REDIR: https://git.k8s.io/4025/ => https://github.com/kubernetes/4025/
REDIR: http://git.k8s.io/4076/4861 => https://github.com/kubernetes/4076/blob/master/4861
REDIR: https://git.k8s.io/4076/4861 => https://github.com/kubernetes/4076/blob/master/4861
REDIR: http://git.kubernetes.io => https://github.com/kubernetes/
REDIR: https://git.kubernetes.io => https://github.com/kubernetes/
REDIR: http://git.kubernetes.io/8021 => https://github.com/kubernetes/8021/
REDIR: https://git.kubernetes.io/8021 => https://github.com/kubernetes/8021/
REDIR: http://git.kubernetes.io/9338/ => https://github.com/kubernetes/9338/
REDIR: https://git.kubernetes.io/9338/ => https://github.com/kubernetes/9338/
REDIR: http://git.kubernetes.io/4257/3005 => https://github.com/kubernetes/4257/blob/master/3005
REDIR: https://git.kubernetes.io/4257/3005 => https://github.com/kubernetes/4257/blob/master/3005
REDIR: http://go.k8s.io/bot-commands => https://prow.k8s.io/command-help
REDIR: https://go.k8s.io/bot-commands => https://prow.k8s.io/command-help
REDIR: http://go.k8s.io/github-labels => https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md
REDIR: https://go.k8s.io/github-labels => https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md
REDIR: http://go.k8s.io/good-first-issue => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+no%3Aassignee
REDIR: https://go.k8s.io/good-first-issue => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+no%3Aassignee
REDIR: http://go.k8s.io/help-wanted => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+no%3Aassignee
REDIR: https://go.k8s.io/help-wanted => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+no%3Aassignee
REDIR: http://go.k8s.io/oncall => https://storage.googleapis.com/test-infra-oncall/oncall.html
REDIR: https://go.k8s.io/oncall => https://storage.googleapis.com/test-infra-oncall/oncall.html
REDIR: http://go.k8s.io/owners => https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
REDIR: https://go.k8s.io/owners => https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
REDIR: http://go.k8s.io/owners/9006 => https://cs.k8s.io/?q=9006&i=fosho&files=OWNERS&excludeFiles=vendor%2F&repos=
REDIR: https://go.k8s.io/owners/9006 => https://cs.k8s.io/?q=9006&i=fosho&files=OWNERS&excludeFiles=vendor%2F&repos=
REDIR: http://go.k8s.io/partner-request => https://docs.google.com/forms/d/e/1FAIpQLSdN1KtSKX2VAOPGABFlShkSd6CajQynoL4QCVtY0dj76MNDKg/viewform
REDIR: https://go.k8s.io/partner-request => https://docs.google.com/forms/d/e/1FAIpQLSdN1KtSKX2VAOPGABFlShkSd6CajQynoL4QCVtY0dj76MNDKg/viewform
REDIR: http://go.k8s.io/start => https://kubernetes.io/docs/setup/
REDIR: https://go.k8s.io/start => https://kubernetes.io/docs/setup/
REDIR: http://go.k8s.io/test-history => https://storage.googleapis.com/kubernetes-test-history/static/index.html
REDIR: https://go.k8s.io/test-history => https://storage.googleapis.com/kubernetes-test-history/static/index.html
REDIR: http://go.k8s.io/triage => https://storage.googleapis.com/k8s-triage/index.html
REDIR: https://go.k8s.io/triage => https://storage.googleapis.com/k8s-triage/index.html
REDIR: http://go.k8s.io/logo => https://branding.cncf.io/projects/kubernetes/
REDIR: https://go.k8s.io/logo => https://branding.cncf.io/projects/kubernetes/
REDIR: http://go.k8s.io/pr-dashboard => https://gubernator.k8s.io/pr
REDIR: https://go.k8s.io/pr-dashboard => https://gubernator.k8s.io/pr
REDIR: http://go.k8s.io/stuck-prs => https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3Algtm%20label%3Aapproved%20-label%3Ado-not-merge%20-label%3Aneeds-rebase%20sort%3Aupdated-asc%20-status%3Asuccess
REDIR: https://go.k8s.io/stuck-prs => https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3Algtm%20label%3Aapproved%20-label%3Ado-not-merge%20-label%3Aneeds-rebase%20sort%3Aupdated-asc%20-status%3Asuccess
REDIR: http://go.k8s.io/needs-ok-to-test => https://github.com/pulls?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Apr+label%3Aneeds-ok-to-test+label%3A%22cncf-cla%3A+yes%22+-label%3Aneeds-rebase
REDIR: https://go.k8s.io/needs-ok-to-test => https://github.com/pulls?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Apr+label%3Aneeds-ok-to-test+label%3A%22cncf-cla%3A+yes%22+-label%3Aneeds-rebase
REDIR: http://go.kubernetes.io/bot-commands => https://prow.k8s.io/command-help
REDIR: https://go.kubernetes.io/bot-commands => https://prow.k8s.io/command-help
REDIR: http://go.kubernetes.io/github-labels => https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md
REDIR: https://go.kubernetes.io/github-labels => https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md
REDIR: http://go.kubernetes.io/good-first-issue => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+no%3Aassignee
REDIR: https://go.kubernetes.io/good-first-issue => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+no%3Aassignee
REDIR: http://go.kubernetes.io/help-wanted => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+no%3Aassignee
REDIR: https://go.kubernetes.io/help-wanted => https://github.com/issues?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+no%3Aassignee
REDIR: http://go.kubernetes.io/oncall => https://storage.googleapis.com/test-infra-oncall/oncall.html
REDIR: https://go.kubernetes.io/oncall => https://storage.googleapis.com/test-infra-oncall/oncall.html
REDIR: http://go.kubernetes.io/owners => https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
REDIR: https://go.kubernetes.io/owners => https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
REDIR: http://go.kubernetes.io/owners/8267 => https://cs.k8s.io/?q=8267&i=fosho&files=OWNERS&excludeFiles=vendor%2F&repos=
REDIR: https://go.kubernetes.io/owners/8267 => https://cs.k8s.io/?q=8267&i=fosho&files=OWNERS&excludeFiles=vendor%2F&repos=
REDIR: http://go.kubernetes.io/partner-request => https://docs.google.com/forms/d/e/1FAIpQLSdN1KtSKX2VAOPGABFlShkSd6CajQynoL4QCVtY0dj76MNDKg/viewform
REDIR: https://go.kubernetes.io/partner-request => https://docs.google.com/forms/d/e/1FAIpQLSdN1KtSKX2VAOPGABFlShkSd6CajQynoL4QCVtY0dj76MNDKg/viewform
REDIR: http://go.kubernetes.io/start => https://kubernetes.io/docs/setup/
REDIR: https://go.kubernetes.io/start => https://kubernetes.io/docs/setup/
REDIR: http://go.kubernetes.io/test-history => https://storage.googleapis.com/kubernetes-test-history/static/index.html
REDIR: https://go.kubernetes.io/test-history => https://storage.googleapis.com/kubernetes-test-history/static/index.html
REDIR: http://go.kubernetes.io/triage => https://storage.googleapis.com/k8s-triage/index.html
REDIR: https://go.kubernetes.io/triage => https://storage.googleapis.com/k8s-triage/index.html
REDIR: http://go.kubernetes.io/logo => https://branding.cncf.io/projects/kubernetes/
REDIR: https://go.kubernetes.io/logo => https://branding.cncf.io/projects/kubernetes/
REDIR: http://go.kubernetes.io/pr-dashboard => https://gubernator.k8s.io/pr
REDIR: https://go.kubernetes.io/pr-dashboard => https://gubernator.k8s.io/pr
REDIR: http://go.kubernetes.io/stuck-prs => https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3Algtm%20label%3Aapproved%20-label%3Ado-not-merge%20-label%3Aneeds-rebase%20sort%3Aupdated-asc%20-status%3Asuccess
REDIR: https://go.kubernetes.io/stuck-prs => https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3Algtm%20label%3Aapproved%20-label%3Ado-not-merge%20-label%3Aneeds-rebase%20sort%3Aupdated-asc%20-status%3Asuccess
REDIR: http://go.kubernetes.io/needs-ok-to-test => https://github.com/pulls?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Apr+label%3Aneeds-ok-to-test+label%3A%22cncf-cla%3A+yes%22+-label%3Aneeds-rebase
REDIR: https://go.kubernetes.io/needs-ok-to-test => https://github.com/pulls?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-csi+org%3Akubernetes-client+is%3Aopen+is%3Apr+label%3Aneeds-ok-to-test+label%3A%22cncf-cla%3A+yes%22+-label%3Aneeds-rebase
REDIR: http://k8s.io/kubernetes?go-get=1 => https://k8s.io/kubernetes?go-get=1
GET: https://k8s.io/kubernetes?go-get=1 => 200
REDIR: http://sigs.k8s.io/example-test-repo?go-get=1 => https://sigs.k8s.io/example-test-repo?go-get=1
GET: https://sigs.k8s.io/example-test-repo?go-get=1 => 200
GET: http://k8s.io/_healthz => 200
GET: https://k8s.io/_healthz => 200
REDIR: http://issues.k8s.io/8246 => https://github.com/kubernetes/kubernetes/issues/8246
REDIR: https://issues.k8s.io/8246 => https://github.com/kubernetes/kubernetes/issues/8246
REDIR: http://issue.k8s.io/2213 => https://github.com/kubernetes/kubernetes/issues/2213
REDIR: https://issue.k8s.io/2213 => https://github.com/kubernetes/kubernetes/issues/2213
REDIR: http://issues.kubernetes.io/1943 => https://github.com/kubernetes/kubernetes/issues/1943
REDIR: https://issues.kubernetes.io/1943 => https://github.com/kubernetes/kubernetes/issues/1943
REDIR: http://issue.kubernetes.io/2929 => https://github.com/kubernetes/kubernetes/issues/2929
REDIR: https://issue.kubernetes.io/2929 => https://github.com/kubernetes/kubernetes/issues/2929
REDIR: http://kep.k8s.io => https://github.com/kubernetes/enhancements/issues/
REDIR: https://kep.k8s.io => https://github.com/kubernetes/enhancements/issues/
REDIR: http://kep.k8s.io/2951 => https://github.com/kubernetes/enhancements/issues/2951
REDIR: https://kep.k8s.io/2951 => https://github.com/kubernetes/enhancements/issues/2951
REDIR: http://kep.kubernetes.io => https://github.com/kubernetes/enhancements/issues/
REDIR: https://kep.kubernetes.io => https://github.com/kubernetes/enhancements/issues/
REDIR: http://kep.kubernetes.io/1573 => https://github.com/kubernetes/enhancements/issues/1573
REDIR: https://kep.kubernetes.io/1573 => https://github.com/kubernetes/enhancements/issues/1573
REDIR: https://k8s.io => https://kubernetes.io/
REDIR: https://k8s.io/ => https://kubernetes.io/
REDIR: https://k8s.io//3457 => https://kubernetes.io//3457
REDIR: http://pr-test.kubernetes.io => https://gubernator.k8s.io
REDIR: https://pr-test.kubernetes.io => https://gubernator.k8s.io
REDIR: http://pr-test.kubernetes.io/2705 => https://gubernator.k8s.io/pr/2705
REDIR: https://pr-test.kubernetes.io/2705 => https://gubernator.k8s.io/pr/2705
REDIR: http://kubernetes.io => https://kubernetes.io/
REDIR: http://kubernetes.io/ => https://kubernetes.io/
REDIR: http://k8s.io => https://k8s.io/
REDIR: http://k8s.io/ => https://k8s.io/
REDIR: http://sigs.k8s.io => https://sigs.k8s.io/
REDIR: http://sigs.k8s.io/ => https://sigs.k8s.io/
REDIR: http://sigs.kubernetes.io => https://sigs.kubernetes.io/
REDIR: http://sigs.kubernetes.io/ => https://sigs.kubernetes.io/
REDIR: http://kubernetes.io/8976 => https://kubernetes.io/8976
REDIR: http://k8s.io/8976 => https://k8s.io/8976
REDIR: http://sigs.k8s.io/8976 => https://sigs.k8s.io/8976
REDIR: http://sigs.kubernetes.io/8976 => https://sigs.kubernetes.io/8976
REDIR: http://prs.k8s.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: https://prs.k8s.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: http://prs.k8s.io/4661 => https://github.com/kubernetes/kubernetes/pull/4661
REDIR: https://prs.k8s.io/4661 => https://github.com/kubernetes/kubernetes/pull/4661
REDIR: http://pr.k8s.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: https://pr.k8s.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: http://pr.k8s.io/4649 => https://github.com/kubernetes/kubernetes/pull/4649
REDIR: https://pr.k8s.io/4649 => https://github.com/kubernetes/kubernetes/pull/4649
REDIR: http://prs.kubernetes.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: https://prs.kubernetes.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: http://prs.kubernetes.io/6989 => https://github.com/kubernetes/kubernetes/pull/6989
REDIR: https://prs.kubernetes.io/6989 => https://github.com/kubernetes/kubernetes/pull/6989
REDIR: http://pr.kubernetes.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: https://pr.kubernetes.io => https://github.com/kubernetes/kubernetes/pulls
REDIR: http://pr.kubernetes.io/2952 => https://github.com/kubernetes/kubernetes/pull/2952
REDIR: https://pr.kubernetes.io/2952 => https://github.com/kubernetes/kubernetes/pull/2952
REDIR: http://releases.k8s.io => https://github.com/kubernetes/kubernetes/releases
REDIR: https://releases.k8s.io => https://github.com/kubernetes/kubernetes/releases
REDIR: http://releases.k8s.io/6203/4346 => https://github.com/kubernetes/kubernetes/tree/6203/4346
REDIR: https://releases.k8s.io/6203/4346 => https://github.com/kubernetes/kubernetes/tree/6203/4346
REDIR: http://rel.k8s.io => https://github.com/kubernetes/kubernetes/releases
REDIR: https://rel.k8s.io => https://github.com/kubernetes/kubernetes/releases
REDIR: http://rel.k8s.io/9251/4737 => https://github.com/kubernetes/kubernetes/tree/9251/4737
REDIR: https://rel.k8s.io/9251/4737 => https://github.com/kubernetes/kubernetes/tree/9251/4737
REDIR: http://releases.kubernetes.io => https://github.com/kubernetes/kubernetes/releases
REDIR: https://releases.kubernetes.io => https://github.com/kubernetes/kubernetes/releases
REDIR: http://releases.kubernetes.io/8887/2331 => https://github.com/kubernetes/kubernetes/tree/8887/2331
REDIR: https://releases.kubernetes.io/8887/2331 => https://github.com/kubernetes/kubernetes/tree/8887/2331
REDIR: http://rel.kubernetes.io => https://github.com/kubernetes/kubernetes/releases
REDIR: https://rel.kubernetes.io => https://github.com/kubernetes/kubernetes/releases
REDIR: http://rel.kubernetes.io/2587/4544 => https://github.com/kubernetes/kubernetes/tree/2587/4544
REDIR: https://rel.kubernetes.io/2587/4544 => https://github.com/kubernetes/kubernetes/tree/2587/4544
REDIR: https://sigs.k8s.io => https://github.com/kubernetes-sigs/
REDIR: https://sigs.k8s.io/5846 => https://github.com/kubernetes-sigs/5846
REDIR: https://sigs.k8s.io/8236/ => https://github.com/kubernetes-sigs/8236/
REDIR: https://sigs.k8s.io/1922/2088 => https://github.com/kubernetes-sigs/1922/blob/master/2088
REDIR: https://sigs.kubernetes.io => https://github.com/kubernetes-sigs/
REDIR: https://sigs.kubernetes.io/3420 => https://github.com/kubernetes-sigs/3420
REDIR: https://sigs.kubernetes.io/5333/ => https://github.com/kubernetes-sigs/5333/
REDIR: https://sigs.kubernetes.io/8914/2970 => https://github.com/kubernetes-sigs/8914/blob/master/2970
REDIR: http://submit-queue.k8s.io => https://prow.k8s.io/tide
REDIR: https://submit-queue.k8s.io => https://prow.k8s.io/tide
REDIR: http://submit-queue.k8s.io/4630 => https://prow.k8s.io/tide
REDIR: https://submit-queue.k8s.io/4630 => https://prow.k8s.io/tide
REDIR: http://submit-queue.kubernetes.io => https://prow.k8s.io/tide
REDIR: https://submit-queue.kubernetes.io => https://prow.k8s.io/tide
REDIR: http://submit-queue.kubernetes.io/5939 => https://prow.k8s.io/tide
REDIR: https://submit-queue.kubernetes.io/5939 => https://prow.k8s.io/tide
REDIR: http://yt.k8s.io => https://www.youtube.com/c/kubernetescommunity
REDIR: https://yt.k8s.io => https://www.youtube.com/c/kubernetescommunity
REDIR: http://yt.k8s.io/7911 => https://www.youtube.com/c/kubernetescommunity
REDIR: https://yt.k8s.io/7911 => https://www.youtube.com/c/kubernetescommunity
REDIR: http://youtube.k8s.io => https://www.youtube.com/c/kubernetescommunity
REDIR: https://youtube.k8s.io => https://www.youtube.com/c/kubernetescommunity
REDIR: http://youtube.k8s.io/8824 => https://www.youtube.com/c/kubernetescommunity
REDIR: https://youtube.k8s.io/8824 => https://www.youtube.com/c/kubernetescommunity
REDIR: http://youtube.kubernetes.io => https://www.youtube.com/c/kubernetescommunity
REDIR: https://youtube.kubernetes.io => https://www.youtube.com/c/kubernetescommunity
REDIR: http://youtube.kubernetes.io/6062 => https://www.youtube.com/c/kubernetescommunity
REDIR: https://youtube.kubernetes.io/6062 => https://www.youtube.com/c/kubernetescommunity
REDIR: http://yt.kubernetes.io => https://www.youtube.com/c/kubernetescommunity
REDIR: https://yt.kubernetes.io => https://www.youtube.com/c/kubernetescommunity
REDIR: http://yt.kubernetes.io/4755 => https://www.youtube.com/c/kubernetescommunity
REDIR: https://yt.kubernetes.io/4755 => https://www.youtube.com/c/kubernetescommunity
REDIR: http://yum.k8s.io => https://packages.cloud.google.com/yum/
REDIR: https://yum.k8s.io => https://packages.cloud.google.com/yum/
REDIR: http://yum.k8s.io/7700 => https://packages.cloud.google.com/yum/7700
REDIR: https://yum.k8s.io/7700 => https://packages.cloud.google.com/yum/7700
REDIR: http://yum.kubernetes.io => https://packages.cloud.google.com/yum/
REDIR: https://yum.kubernetes.io => https://packages.cloud.google.com/yum/
REDIR: http://yum.kubernetes.io/3686 => https://packages.cloud.google.com/yum/3686
REDIR: https://yum.kubernetes.io/3686 => https://packages.cloud.google.com/yum/3686
----------------------------------------------------------------------
Ran 26 tests in 12.614s

OK

@dims
Copy link
Member Author

dims commented Feb 5, 2022

looks like it works!

[dims@dims-m1-6480 21:29] ~/go/src/k8s.io/k8s.io ⟩ curl -i -k -H hostname=k8s.io https://k8s.io/internal/foo/bar?go-get=1
HTTP/2 200
server: nginx
date: Sat, 05 Feb 2022 02:29:45 GMT
content-type: text/plain
content-length: 584
via: 1.1 google
alt-svc: clear


            <html><head>
                  <meta name="go-import"
                        content="k8s.io/internal/foo
                                 git https://github.com/k8s-internal/foo">
                  <meta name="go-source"
                        content="k8s.io/internal/foo
                                 https://github.com/k8s-internal/foo
                                 https://github.com/k8s-internal/foo/tree/master{/dir}
                                 https://github.com/k8s-internal/foo/blob/master{/dir}/{file}#L{line}">
            </head></html>

@dims
Copy link
Member Author

dims commented Feb 5, 2022

go get works as well!

[dims@dims-m1-6480 21:31] ~/go/src/k8s.io/kubernetes ⟩ go get k8s.io/internal/distribution
go: downloading k8s.io/internal/distribution v0.0.0-20220126150042-5582208b4e44
go get: added k8s.io/internal/distribution v0.0.0-20220126150042-5582208b4e44

@ameukam
Copy link
Member

ameukam commented Feb 5, 2022

/lgtm
/hold

Please, remove the hold when you're ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2022
@sftim
Copy link
Contributor

sftim commented Feb 5, 2022

Also LGTM (this does not look like it would interfere with the main Kubernetes website).

@dims
Copy link
Member Author

dims commented Feb 6, 2022

Don't think this is going to work. reverted the change to both canary and prod

@dims dims closed this Feb 6, 2022
@dims
Copy link
Member Author

dims commented Feb 6, 2022

verifiied revert by testing

davanum@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ curl -i -k -H hostname=k8s.io https://k8s.io/internal/foo/bar?go-get=1
HTTP/2 200
server: nginx
date: Sun, 06 Feb 2022 22:21:08 GMT
content-type: text/plain
content-length: 588
via: 1.1 google
alt-svc: clear


            <html><head>
                  <meta name="go-import"
                        content="k8s.io/internal
                                 git https://github.com/kubernetes/internal">
                  <meta name="go-source"
                        content="k8s.io/internal
                                 https://github.com/kubernetes/internal
                                 https://github.com/kubernetes/internal/tree/master{/dir}
                                 https://github.com/kubernetes/internal/blob/master{/dir}/{file}#L{line}">
            </head></html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@aojea aojea Awaiting requested review from aojea

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @k8s-ci-robot @thockin @ameukam @sftim