Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote descheduler images to v0.24.0 #3739

Merged
merged 1 commit into from
May 23, 2022
Merged

Promote descheduler images to v0.24.0 #3739

merged 1 commit into from
May 23, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 17, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2022
damemi
damemi commented May 17, 2022
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ingvagabund

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label May 17, 2022
@k8s-ci-robot k8s-ci-robot added area/k8s.gcr.io Code in k8s.gcr.io/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels May 17, 2022
@damemi
Copy link
Contributor Author

damemi commented May 17, 2022

/hold
just double checking the process is set up right

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2022
@damemi damemi mentioned this pull request May 17, 2022
Closed
9 tasks
@damemi
Copy link
Contributor Author

damemi commented May 17, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2022
@damemi
Copy link
Contributor Author

damemi commented May 18, 2022

/hold
holding again because we may want to include kubernetes-sigs/descheduler#801 in this release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@damemi damemi mentioned this pull request May 18, 2022
Merged
@seanmalloy
Copy link
Member

I verified all the image SHA's are correct.

I'm my opinion it is safe to promote this image. A follow up release v0.24.1 can be done to bump to Go version 1.18.2. See below comments for reference.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@damemi
Copy link
Contributor Author

damemi commented May 23, 2022

/hold cancel
like @seanmalloy said, we'll go ahead with these for v0.24.0 and publish a v0.24.1 patch for go1.18.2

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 33eccf6 into kubernetes:main May 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@damemi @k8s-ci-robot @seanmalloy