Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image promotion for build-image v1.25.0-go1.19-bullseye.0 / v2.3.1-go1.19-bullseye.0 #4047

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Image promotion for build-image v1.25.0-go1.19-bullseye.0 / v2.3.1-go1.19-bullseye.0 #4047

merged 1 commit into from
Aug 4, 2022

Conversation

puerco
Copy link
Member

@puerco puerco commented Aug 4, 2022

Image promotion for build-image v1.25.0-go1.19-bullseye.0 / v2.3.1-go1.19-bullseye.0
This is an automated PR generated from kpromo

kpromo pr --fork puerco --interactive --project build-image --tag v1.25.0-go1.19-bullseye.0 --tag v2.3.1-go1.19-bullseye.0

/hold
cc: @kubernetes/release-engineering

@puerco
Image promotion for build-image v1.25.0-go1.19-bullseye.0 / v2.3.1-go…
94c8093 
…1.19-bullseye.0

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2022
@Verolop
Copy link
Contributor

Verolop commented Aug 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@dims
Copy link
Member

dims commented Aug 4, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco puerco mentioned this pull request Aug 4, 2022
Closed
40 tasks
@puerco
Copy link
Member Author

puerco commented Aug 4, 2022

For some reason, we have a big diff reordering the last PR to the manifests. I've checked and beyond moving things, the diff is only adding new digests which are related to the tags being promoted:

diff -u diff-subtracted diff-added  | grep '^+'
+++ diff-added	2022-08-03 20:36:04.040968527 -0500
+++ images-post-sort.yaml	2022-08-03 20:31:15.211051147 -0500
+    "sha256:717e60621982407732a6ee017b39eeb207e2a652dc36e0da5a418f08d52f0b16": ["v1.25.0-go1.19-bullseye.0"]
+    "sha256:8a9fcfe33e2b9be867edc7e4130bc7aa7062fe3c2e20e30f97ddec85598936f9": ["v1.25.0-go1.19-bullseye.0"]
+    "sha256:90660d597854f35e65db372c139842d68a9a51b736e351bb97c90dc0d61c99a5": ["v1.25.0-go1.19-bullseye.0"]
+    "sha256:a4912366fd8049fb4ab39ac90974876123d9b790f2c4b692b7ba8fe8c79d65a5": ["v2.3.1-go1.19-bullseye.0"]
+    "sha256:aabc8e18783238e181f922589f0c5a5fb77bb83a8b1a7f10a9cb54d920b4418d": ["v1.25.0-go1.19-bullseye.0"]
+    "sha256:b855b6fa087d96d843817d63320184c62b39eb876e787086c558a21acdd7ed8c": ["v1.25.0-go1.19-bullseye.0"]
+    "sha256:cab181716abc1f204168f56d5f86a00741c8108e28af01b424f9b3cddd5cf8c9": ["v2.3.1-go1.19-bullseye.0"]
+    "sha256:e3435280c66cb9cde54f42aeeac442fed2bb06a00ae119649afb92e9313e0abb": ["v2.3.1-go1.19-bullseye.0"]
+    "sha256:f5c7f5e1333900da2fe27754cd3eeaba439102feb83bdddf59cec7f44b71d88f": ["v2.3.1-go1.19-bullseye.0"]
+    "sha256:f7b91deba112f6547fa5b1a66f86af9b0ecd01d62defa554bfd132d1cea97ec4": ["v2.3.1-go1.19-bullseye.0"]
+    "sha256:f887b907dc70f162d467c27962dc702af228b096a5c93e6320af7eeb09bacf37": ["v2.3.1-go1.19-bullseye.0"]

This means the promo PR is OK. After the manifest sorting was merged, this should not happen but once. @kubernetes/release-managers let's make sure everybody is using the latest kpromo version.

@puerco
Copy link
Member Author

puerco commented Aug 4, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8787040 into kubernetes:main Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 4, 2022
@puerco puerco deleted the build-image-v1.25.0-go1.19-bullseye.0-image-promotion branch August 4, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@dims dims

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@puerco @Verolop @dims @k8s-ci-robot