Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first pass mapping cloud run regions to S3 regions #4739

Merged
merged 1 commit into from
Feb 8, 2023
Merged

first pass mapping cloud run regions to S3 regions #4739

merged 1 commit into from
Feb 8, 2023

Conversation

BenTheElder
Copy link
Member

xref: kubernetes/registry.k8s.io#147

this environment variable doesn't do anything yet, it will after we update to kubernetes/registry.k8s.io#147

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims February 8, 2023 20:45
@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin February 8, 2023 20:45
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 8, 2023
This was referenced Feb 8, 2023
Merged
Closed
justinsb
justinsb reviewed Feb 8, 2023
View reviewed changes
infra/gcp/terraform/k8s-infra-oci-proxy-prod/terraform.tfvars Show resolved Hide resolved
infra/gcp/terraform/k8s-infra-oci-proxy-prod/terraform.tfvars Outdated
{
name = "DEFAULT_AWS_BASE_URL",
// AWS us-west-1 is California, USA
value = "https://prod-registry-k8s-io-us-west-1.s3.dualstack.us-west-2.amazonaws.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: us-west-1 and us-west-2 in same URL, should match I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ben

@justinsb
Copy link
Member

justinsb commented Feb 8, 2023

LGTM though I think you need to fix that second URL

Do you want to do this in sandbox first / as well?

@BenTheElder
Copy link
Member Author

LGTM though I think you need to fix that second URL

which URL? I think I fixed everything?

Do you want to do this in sandbox first / as well?

good idea, though we auto deploy to the sandbox using some bash in the registry repo currently, we don't use the terraform currently

@BenTheElder
Copy link
Member Author

I think letting the sandbox default to one region is OK, we only have some test CI aimed at it. No end users should be using the sandbox endpoint and only a very limited subset of CI. We have a default-default.

@ameukam
Copy link
Member

ameukam commented Feb 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@ameukam
Copy link
Member

ameukam commented Feb 8, 2023

/approve
/hold

Remove the hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 65efcc0 into kubernetes:main Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 8, 2023
@BenTheElder BenTheElder deleted the map-gcp-aws branch February 8, 2023 21:24
@BenTheElder
Copy link
Member Author

terraform applyed

@BenTheElder BenTheElder mentioned this pull request Mar 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@BenTheElder @justinsb @ameukam @k8s-ci-robot @dims