Add node-feature-discovery (nfd) to k8s.gcr.io

[marquiz]

We would like to host images for node-feature-discovery in k8s.gcr.io, see kubernetes-sigs/node-feature-discovery#177

Upstream project name (node-feature-discovery) exceeds the 18 character limit mentioned in k8s.gcr.io/README.md so it was abbreviated to nfd here. I don't know if it would be possible/make sense to use the full name in the name of the registry (i.e. in ensure-staging-storage.sh and k8s-staging-nfd/promoter-manifest.yaml)(?)

/sig node

[k8s-ci-robot]

Welcome @marquiz!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @marquiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marquiz]

/assign @bartsmykla

[ArangoGutierrez]

++

[thockin]

@bartsmykla Will cross Ts and dot Is, but this seems OK. Problem with OWNERS is real - maybe just do Derek or someone else who can approve until people are org members?

[thockin]

I'm not in love with "nfd" - is there anything else we can find?

…

On Wed, Feb 5, 2020 at 9:09 AM Kubernetes Prow Robot < ***@***.***> wrote: @marquiz <https://github.com/marquiz>: PR needs rebase. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#524?email_source=notifications&email_token=ABKWAVD23J7TD4UQ3B3BEVTRBLXEBA5CNFSM4J4MEVSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4GXRI#issuecomment-582511557>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVGJZE4UIXYO6KAAGF3RBLXEBANCNFSM4J4MEVSA> .

[marquiz]

Rebased.

I'm not in love with "nfd" - is there anything else we can find?

Me neither but I couldn't come up with anything better as nfd or NFD is a commonly used acronym for the project.

I repeat my question from the PR submission: Would be possible/make sense to use the full name in the name of the registries (i.e. in ensure-staging-storage.sh and k8s-staging-nfd/promoter-manifest.yaml)?

[thockin]

The name of the subproject (nfd) is used to create GCS buckets, GCP projects, etc. We are bound by GCP's character limits on those, and (for better or worse) our prefix is established. To change it now would be forever inconsistent :(

The image name(s) that you use can be longer - I don't think we have a strong opinion on that (e.g. gcr.io/k8s-artifacts-prod/nfd/node-feature-detector and eventually k8s.gcr.io/...). We would not want to change the "directory" part of it though. That name-mapping is very convenient

[thockin]

BTW, we still have invalid OWNERS :(

[bartsmykla]

I don't have strong opinion about the acronym, and everything except the OWNERS file look good to me.
@marquiz could you fix the issue with owners?

[marquiz]

The name of the subproject (nfd) is used to create GCS buckets, GCP projects, etc. We are bound by GCP's character limits on those, and (for better or worse) our prefix is established. To change it now would be forever inconsistent :(

@thockin thanks for the explanation

@marquiz could you fix the issue with owners?

I fixed that by removing all non-members from the owners file. There's now only one owner, do you think we would require to have more?

[thockin]

More would be nice, but maybe isn't a requirement at this point.

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: marquiz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thockin]

Actuating now