kops-ci: Use container image for boostrap #6168
Conversation
Follow-up of: - kubernetes#6148 Use a custom image for bootstrap since Bottlerocket only TOML format for bootstrap Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/infra
| util-linux \ | ||
| xfsprogs | ||
|
|
||
| ADD https://raw.githubusercontent.com/kubernetes/k8s.io/a8be6bcc88c61dc55ce0f6b888e7f4e6c0a5293d/infra/aws/terraform/prow-build-cluster/bootstrap_bottlerocket/node_bootstrap.sh /bootstrap.sh |
There was a problem hiding this comment.
this this make it harder to update bootstrap.sh in the future? (update the script in one PR and then fix up the SHA here in the next one?)
There was a problem hiding this comment.
Assuming we are doing a lot of changes for this. We are not gonna change the instance type for a while (specially if we use 1-year committement) and the script is pretty stable.
Happy to use the ref of a branch if you want.
There was a problem hiding this comment.
There was a problem hiding this comment.
Theres also https://github.com/topolvm/topolvm which isn't marked experimental - would be flexible across OS variants and if we change instance types, etc.
There was a problem hiding this comment.
the static provisioner looks interesting. I can follow-up with that.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Follow-up of:
Use a custom image for bootstrap since Bottlerocket only TOML format for bootstrap