re-add some deleted image references #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively reverts the following commits:
7958a48
fcc4b7a
ca4467d
ba005de
This is to make the promoter manifests more accurate, to account for
what has already been promoted into production (otherwise, when auditing
the production GCR contents, one is forced to dig into the commit
history).
Deletions of items in the promoter manifests shouldn't normally be
allowed because they make the manifests ignore the reality of the images
actually still existing in production.
k8s-ci-robot
added
cncf-cla: yes
|
/cc @thockin |
|
/assign |
|
We'll have to socialize the idea that you don't "clean up" in these - whatever gets committed is forever. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts the following commits:
This is to make the promoter manifests more accurate, to account for
what has already been promoted into production (otherwise, when auditing
the production GCR contents, one is forced to dig into the commit
history).
Deletions of items in the promoter manifests shouldn't normally be
allowed because they make the manifests ignore the reality of the images
actually still existing in production.