Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops-ci: Bump EKS module #6559

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 12, 2024

Bump to v20.x version

Introducing:

  • Access entries
  • Karpenter support
  • AL2023 support
  • tags on launch templates instead of the node group

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin March 12, 2024 15:37
@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

cc @bryantbiggs

I see this in the terraform plan:

  # module.eks.time_sleep.this[0] must be replaced
+/- resource "time_sleep" "this" {
      ~ id              = "2023-12-05T08:28:21Z" -> (known after apply)
      ~ triggers        = { # forces replacement
          + "cluster_service_cidr"               = "172.20.0.0/16"
            # (4 unchanged elements hidden)
        }
        # (1 unchanged attribute hidden)
    }

Is it expected ?

@bryantbiggs
Copy link
Contributor

yes - see terraform-aws-modules/terraform-aws-eks#2963

Bump to v20.x version

Introducing:
- Access entries
- Karpenter support
- AL2023 support
- tags on launch templates instead of the node group

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

/hold cancel
I think we are good to go.

cc @bryantbiggs @hakman @rifelpet

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@hakman
Copy link
Member

hakman commented Mar 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 🚀

@k8s-ci-robot
Copy link
Contributor

@bryantbiggs: changing LGTM is restricted to collaborators

In response to this:

/lgtm 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, bryantbiggs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2af6ef5 into kubernetes:main Mar 12, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants