Grant kubernetes-release-test GCB write on k8s-staging-kubernetes GCR #673
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
infra/gcp/ensure-staging-storage.sh
Outdated
| @@ -80,6 +80,8 @@ RELEASE_STAGING_PROJECTS=( | |||
| releng | |||
| ) | |||
|
|
|||
| RELEASE_OLD_STAGING_CLOUDBUILD_ACCOUNT="648026197307@cloudbuild.gserviceaccount.com" | |||
There was a problem hiding this comment.
Nit: move "OLD" to the front
There was a problem hiding this comment.
Also, maybe comment this to say that this is the GCB build account for the 'kubernetes-release-test' project, to line up with the comments in line 195.
infra/gcp/ensure-staging-storage.sh
Outdated
| # completely moving staging to K8s Infra until dl.k8s.io is moved as well. | ||
| # | ||
| # ref: https://github.com/kubernetes/release/issues/1176 | ||
| if [[ $PROJECT == "k8s-staging-kubernetes" ]]; then |
There was a problem hiding this comment.
Nit: "${PROJECT}" for consistency
justaugustus
force-pushed
the
releng-vdf
branch
from
4549389 to
545f5cb
Compare
|
@listx -- Fixed! |
infra/gcp/ensure-staging-storage.sh
Outdated
| # completely moving staging to K8s Infra until dl.k8s.io is moved as well. | ||
| # | ||
| # ref: https://github.com/kubernetes/release/issues/1176 | ||
| if [[ ${PROJECT} == "k8s-staging-kubernetes" ]]; then |
There was a problem hiding this comment.
Micro-nit: "${PROJECT}" with quotes
/lgtm
k8s-ci-robot
added
the
lgtm
Grant the 'kubernetes-release-test' Cloud Build account write access to
the container artifacts GCS location for 'k8s-staging-kubernetes'
('gs://artifacts.k8s-staging-kubernetes.appspot.com').
This currently is a requirement as a domain restriction organization
policy is in place on the Google Infra projects, which prevents us from
completely moving staging to K8s Infra until dl.k8s.io is moved as well.
ref: kubernetes/release#1176
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
justaugustus
force-pushed
the
releng-vdf
branch
from
545f5cb to
4cc09c9
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm @thockin PTAL |
k8s-ci-robot
added
the
lgtm
|
Superseded by #675. |
|
@justaugustus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Grant the
kubernetes-release-testCloud Build account write access tothe container artifacts GCS location for
k8s-staging-kubernetes(
gs://artifacts.k8s-staging-kubernetes.appspot.com).This currently is a requirement as a domain restriction organization
policy is in place on the Google Infra projects, which prevents us from
completely moving staging to K8s Infra until dl.k8s.io is moved as well.
Signed-off-by: Stephen Augustus saugustus@vmware.com
/assign @thockin @dims @cblecker
cc: @tpepper @kubernetes/release-engineering
ref: kubernetes/release#1199, kubernetes/release#270, kubernetes/release#911, kubernetes/release#1176