Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete nginx ingress and add some dns records for services on the utility cluster #7302

Merged
merged 1 commit into from
Sep 17, 2024
Merged

delete nginx ingress and add some dns records for services on the utility cluster #7302

merged 1 commit into from
Sep 17, 2024

Conversation

upodroid
Copy link
Member

  1. nginx ingress is too buggy to deploy something like this that I need to expose ArgoCD https://mykubert.com/blog/ollama-kubernetes-deployment-cost-effective-and-secure/#Security_Setup_with_OAuth2_Proxy_and_Keycloak
  2. One of the reasons why we need to use a custom ingress instead of gce ingress is to support multi cluster observability for Thanos https://wrossmann.medium.com/putting-thanos-grpc-endpoints-behind-a-k8s-ingress-a5e21c7d0d85, as well as the complex proxy for argo.

I'm also adding DNS records for services in the utility cluster.

/cc @ameukam @BenTheElder

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024
upodroid
upodroid commented Sep 16, 2024
View reviewed changes
dns/zone-configs/k8s.io._0_base.yaml
@@ -269,9 +271,28 @@ hooks.prow:
- type: AAAA
ttl: 600 # this has needed to change in the past
value: "2600:1901:0:b465::"
# prow-certificates in k8s-infra-prow project
_acme-challenge.prow:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted unintentionally in #7206

@ameukam
Copy link
Member

ameukam commented Sep 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 95975b0 into kubernetes:main Sep 17, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @k8s-ci-robot @ameukam